Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): adding publishing workers count and errors count #192

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat(metrics): adding publishing workers count and errors count #192

merged 3 commits into from
Nov 13, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Nov 9, 2023 •
edited
Loading

Description

This PR adds the following metrics and Grafana panels for the publishing workers:

  • Current spawned publishing workers count,
  • Workers errors counter (increased when the worker ended up with the error). This is useful to track workers' health status.

Resolves #186

How Has This Been Tested?

Build and CI gate tests.

Due Diligence

  • ⚠️ Requires to be merged on top of the feat: v1 wip #141
  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Nov 9, 2023
@geekbrother geekbrother changed the base branch from main to chore/messaging-refactor November 9, 2023 17:22
@geekbrother geekbrother requested a review from xav November 9, 2023 17:25
@geekbrother geekbrother removed the request for review from xav November 9, 2023 17:33
@geekbrother geekbrother marked this pull request as ready for review November 9, 2023 17:34
chris13524
chris13524 reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be suffixed with _total

terraform/monitoring/panels/app/publishing_workers_count.libsonnet Outdated Show resolved Hide resolved
terraform/monitoring/panels/app/publishing_workers_errors.libsonnet Outdated Show resolved Hide resolved
Base automatically changed from chore/messaging-refactor to main November 10, 2023 13:42
@chris13524 chris13524 self-requested a review November 10, 2023 14:48
@chris13524
Copy link
Member

Plz resolve merge conflicts and I will re-review

@geekbrother geekbrother force-pushed the max/chore/add_spawned_workers_metrics branch from 2f49435 to 60b3e15 Compare November 10, 2023 15:11
@geekbrother geekbrother force-pushed the max/chore/add_spawned_workers_metrics branch from 60b3e15 to ee07a72 Compare November 10, 2023 16:02
@geekbrother geekbrother force-pushed the max/chore/add_spawned_workers_metrics branch from ee07a72 to 7025df0 Compare November 10, 2023 16:13
@geekbrother
Copy link
Contributor Author

Plz resolve merge conflicts and I will re-review

Done, thanks ;)

chris13524
chris13524 approved these changes Nov 10, 2023
View reviewed changes
src/metrics.rs Outdated Show resolved Hide resolved
@geekbrother geekbrother force-pushed the max/chore/add_spawned_workers_metrics branch from 3824411 to 5e96f88 Compare November 13, 2023 10:02
@geekbrother geekbrother merged commit 281cadf into main Nov 13, 2023
13 checks passed
@geekbrother geekbrother deleted the max/chore/add_spawned_workers_metrics branch November 13, 2023 10:15
@geekbrother geekbrother mentioned this pull request Nov 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

Assignees

@geekbrother geekbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: export metrics for spawned workers
2 participants
@geekbrother @chris13524