Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: switch deps from stablelib to noble #5241

Closed
wants to merge 0 commits into from

Conversation

paulmillr
Copy link

@paulmillr paulmillr commented Aug 4, 2024

This has been discussed in https://github.com/orgs/WalletConnect/discussions/4035.

noble is:

  • audited (more audits coming soon)
  • faster
  • smaller
  • used by other libraries (ethers, metamask), which can make them reuse same noble deps
  • popular, issues will be discovered faster

Second part of the change: WalletConnect/walletconnect-utils#185

@chris13524
Copy link
Member

Thanks for the PR!

Can we do a test to ensure that the keys are definitely compatible between these two libraries so we don't break any existing sessions when the library is upgraded?

@paulmillr
Copy link
Author

paulmillr commented Aug 4, 2024

@chris13524 can you clarify how you want the tests to look like? Should I manually create a key with old lib and put it into new impl?

@paulmillr
Copy link
Author

paulmillr commented Aug 8, 2024

@chris13524 ping. Can you tell what to do here:

a. Create static JSON vectors from old implementation, commit them to repo, test with new code
b. Add dependency on old implementation and cross-test random vectors

@chris13524
Copy link
Member

@paulmillr I think of you just do a manual test showing they are interoperable that's fine. Input/output of these functions would be good, don't need to test the whole app

@paulmillr
Copy link
Author

Continuing in #5333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants