Skip to content

fix(ci): short commit hash length #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xDarksome merged 1 commit into from
Nov 13, 2025
Merged

fix(ci): short commit hash length #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/package-binary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ jobs:

- name: Commit hash
run: |
SHA="$(git rev-parse HEAD)"
echo "SHA=$SHA" >> $GITHUB_ENV
echo "SHA_SHORT=${SHA::8}" >> $GITHUB_ENV
SHA_SHORT="$(git rev-parse --short HEAD)"
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --short flag without a specific length can produce variable-length hashes (typically 7 characters, but can increase if needed for uniqueness). For consistency between workflows, consider using --short=7 or --short=8 to ensure a fixed length. This is especially important since release-package.yaml references Docker images tagged with this SHA_SHORT value.

Example:

SHA_SHORT="$(git rev-parse --short=7 HEAD)"

This would ensure both workflows always use the same hash length.

Suggested change
SHA_SHORT="$(git rev-parse --short HEAD)"
SHA_SHORT="$(git rev-parse --short=7 HEAD)"

Copilot uses AI. Check for mistakes.
echo "SHA_SHORT=$SHA_SHORT" >> $GITHUB_ENV

- name: Docker tag
run: echo "TAG=ghcr.io/walletconnect/${PACKAGE}:${SHA_SHORT}-${ARCH}" >> $GITHUB_ENV
Expand Down
Loading