feat(infra): export prometheus metrics to s3 #310
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to export Prometheus metrics to S3 using the prom2parquet tool. The changes refactor the service module to support multiple containers per ECS task, enabling the deployment of sidecar containers alongside primary services.
Key Changes
- Refactored the service module to support a list of containers instead of a single container configuration, enabling multi-container ECS task definitions
- Added prom2parquet as an optional sidecar container to the Prometheus service for S3 export functionality
- Updated all existing service configurations (db, node, prometheus, grafana) to use the new containers list structure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| infra/testnet/main.tf | Adds s3_export flag and prom2parquet_image configuration to enable S3 metrics export for the testnet environment |
| infra/modules/service/main.tf | Refactors variable schema and task definition to support multiple containers per service, updates port handling and container definition logic |
| infra/modules/node-operator/main.tf | Adds S3 export configuration variables, updates all service modules (db, node, prometheus, grafana) to use new containers structure, adds prom2parquet sidecar to prometheus when S3 export is enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Due Diligence