chore: refactor waitForSubscriptions

tests/shared/pages/InboxPage.ts

@@ -90,6 +90,21 @@ export class InboxPage {
     return notificationsCount - 1;
   }
 
+  /**
+   * Waits for a specific number of dApps to be subscribed.
+   * 
+   * @param {number} expectedCount - The expected number of dApps to wait for.
+   * @returns {Promise<void>}
+   */
+  async waitForSubscriptions(expectedCount: number): Promise<void> {
+    // Wait for a function that checks the length of a list or a set of elements
+    // matching a certain condition to equal the expectedCount.
+    await this.page.waitForFunction(([className, count]) => {
+      const elements = document.getElementsByClassName(className)[1].children;;
+      return elements.length === count;
+    }, ['AppSelector__list', expectedCount] as const, { timeout: 5000 }); 
+  }
+
   async updatePreferences() {
     await this.page.locator('.AppNotificationsHeader__wrapper > .Dropdown').click()
     await this.page.getByRole('button', { name: 'Preferences' }).click()

tests/subscribe.spec.ts

@@ -70,6 +70,8 @@ test('it should subscribe and unsubscribe to and from multiple dapps', async ({
   await inboxPage.subscribe(0)
   await inboxPage.subscribe(1)
 
+  await inboxPage.waitForSubscriptions(2)
+
   // Wait for the 2 dapps to be subscribed to.
   await inboxPage.page.waitForFunction(() => {
     // Using 1 here since the first `AppSelector__list` is the one with `Discover Apps`