Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add banner to w3i app #373

Merged
merged 9 commits into from
Jan 16, 2024
Merged

refactor: add banner to w3i app #373

merged 9 commits into from
Jan 16, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jan 11, 2024

Description

Adding launch banner for announcing airdrop

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Closes https://github.com/WalletConnect/web3inbox-planning/issues/28

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 10:44am

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +20 to +22
if (closed) {
return null
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference for logic like this is having it be outside of where it's display but I understand why putting it here makes it simpler. I'm okay with this because it's a temporary component

src/hooks/useW3IContext.ts Outdated Show resolved Hide resolved
@enesozturk enesozturk merged commit 8542b13 into main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants