Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support page to settings #384

Merged
merged 7 commits into from
Jan 12, 2024
Merged

feat: add support page to settings #384

merged 7 commits into from
Jan 12, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jan 12, 2024

Description

Add a support page to the settings.

Type of change

  • New feature (non-breaking change which adds functionality)

Fixes/Resolves (Optional)

Closes https://github.com/WalletConnect/web3inbox-planning/issues/39
Closes https://github.com/WalletConnect/web3inbox-planning/issues/50

Examples/Screenshots (Optional)

Screenshot 2024-01-12 at 11 28 21 Screenshot 2024-01-12 at 11 28 32

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 8:26pm

@chadyj
Copy link
Contributor

chadyj commented Jan 12, 2024

Thanks @enesozturk. A few small things:

  1. Typo

Get support our Discord
Should be
Get support at our Discord

  1. Can you please direct link to FAQ with a named anchor?
    eg https://web3inbox.com/#faq

  2. Weird issue when support icon is active. Turns into a blob

Screenshot 2024-01-12 at 11 10 48

@chadyj
Copy link
Contributor

chadyj commented Jan 12, 2024

Also FYI, created a new settings issue https://github.com/WalletConnect/web3inbox-planning/issues/50

@enesozturk
Copy link
Contributor Author

@chadyj Made updates.

An addition; Moved the appearance settings to the second place, since it doesn't have any functionality yet. We could even remove it since we show a feature that doesn't work. Wdyt?

@chadyj
Copy link
Contributor

chadyj commented Jan 12, 2024

Thanks ship it.

Created a reminder issue for the anchor https://github.com/WalletConnect/www-web3inbox/issues/11

@chadyj
Copy link
Contributor

chadyj commented Jan 12, 2024

We could even remove it since we show a feature that doesn't work. Wdyt?

Lets keep it otherwise it looks a little lonely

@enesozturk enesozturk merged commit 9410747 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants