Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update all layout styles #386

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

enesozturk
Copy link
Contributor

Description

Refactor layout styles to fix overflow issues in different situations like; subscription list, notifications (topic) page on mobile, etc.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Fixes/Resolves (Optional)

Closes #379

Examples/Screenshots (Optional)

[See preview for better showcase]

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 7:28pm

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/App.scss Outdated Show resolved Hide resolved
src/App.scss Outdated Show resolved Hide resolved
src/index.css Show resolved Hide resolved
src/App.scss Outdated Show resolved Hide resolved
@enesozturk
Copy link
Contributor Author

Updated the height units to check if the OS supports dvh. This fixes and issue on Android;

Tested on;

  • Web (Chrome, Firefox, Safari)
  • Android simulator
  • iOS simulator

@enesozturk enesozturk merged commit 7ff1ec1 into main Jan 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot scroll to bottom of subscriptions on iOS
2 participants