feat(ui-tests): scaffolds basic test #388

arein · 2024-01-12T13:29:50Z

Basic tests covering subscribe/unsubscribe.

Description

Please include a brief summary of the change.

Type of change

Please put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Fixes/Resolves (Optional)

Please list any issues that are fixed by this PR in the format #<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.

Examples/Screenshots (Optional)

Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.

Use this table template to show examples of your changes:

Before	After
Content Cell	Content Cell
Content Cell	Content Cell

Checklist:

I have performed a self-review of my own code
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

vercel · 2024-01-12T13:29:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-web3inbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 18, 2024 1:10pm

chris13524

yarn.lock shouldn't need to change, can you rebase or whatever?

Also Vercel lint is failing.

chris13524 · 2024-01-15T13:38:08Z

package.json

@@ -56,6 +58,7 @@
    "@vitejs/plugin-react": "^2.2.0",
    "@walletconnect/types": "2.11.0",
    "autoprefixer": "^10.4.14",
+    "dotenv": "16.3.1",


Why was this added? I see the require('dotenv').config(); line was removed below

Suggested change

"dotenv": "16.3.1",

arein · 2024-01-15T13:50:00Z

yarn.lock shouldn't need to change, can you rebase or whatever?

Also Vercel lint is failing.

I had merge conflicts. Removed yarn.lock and ran yarn install

arein · 2024-01-15T13:59:21Z

yarn.lock shouldn't need to change, can you rebase or whatever?

Also Vercel lint is failing.

Vercel is failing due to

``

src/components/settings/PrivacySettings/index.tsx(44,10): error TS2741: Property 'children' is missing in type '{ title: string; subtitle: string; }' but required in type 'IProps'.

08:56:06.184 | error Command failed with exit code 2.


Didn't touch this

chris13524 · 2024-01-15T19:24:19Z

@devceline can you fix this PR?

enesozturk · 2024-01-18T06:38:45Z

@chris13524 I want to take a look at this. I could handle the tests and increase the coverage with the remaining tests

cc @arein

arein · 2024-01-18T11:03:30Z

@chris13524 I want to take a look at this. I could handle the tests and increase the coverage with the remaining tests

cc @arein

@enesozturk thank you. For the scope of this PR the only thing that's blocking is the failing Vercel deployment see:

src/components/settings/PrivacySettings/index.tsx(44,10): error TS2741: Property 'children' is missing in type '{ title: string; subtitle: string; }' but required in type 'IProps'.

Once this is fixed I think we can merge and then you can take over in follow up PRs

* feat(ui-tests): scaffolds basic test * feat: tests * refactor: update breakpoints, handle breakpoint for explorer columns * Fix/force watch subscriptions (#393) * chore: add unregister functionality * chore: add unregister to facade * chore: add unregister others * chore: run prettier * chore(config): ensure Sentry captures `console.error` calls (#400) * chore: remove console capture (#410) * feat(ui-tests): scaffolds basic test * feat: tests * refactor: handle notification modal on ci, refactor tests * refactor: remove privacy settings comp * chore: update selectors * chore: revert apps max width --------- Co-authored-by: Derek <[email protected]> Co-authored-by: Celine Sarafa <[email protected]> Co-authored-by: Ben Kremer <[email protected]>

chris13524

LGTM other than some suggestions for future iterations

chris13524 · 2024-01-18T12:30:42Z

src/Modals.tsx

@@ -96,7 +97,7 @@ export const Modals = () => {

      {shouldShowPWAModal && <PwaModal />}

-      {isNotificationPwaModalOpen && <NotificationPwaModal />}
+      {!isCI && isNotificationPwaModalOpen && <NotificationPwaModal />}


I think we can avoid this flag by granting the notification permission. Also we'll need to test these states anyway so this will have to change.

chris13524 · 2024-01-18T12:35:06Z

tests/shared/pages/InboxPage.ts

+
+import { BASE_URL } from '../constants'
+
+export class ModalPage {


Rename to InboxPage?

chris13524 · 2024-01-18T12:35:57Z

tests/shared/pages/InboxPage.ts

+    await this.page.getByText('Subscribed to', { exact: false }).isVisible()
+  }
+
+  async unsubscribe(nth: number) {


This API will flake in future revisions because number is non-deterministic. Better to select by name.

vercel bot deployed to Preview January 12, 2024 13:30 View deployment

arein force-pushed the feat/tests branch from ce098e7 to 255c15d Compare January 12, 2024 13:34

arein changed the title ~~Feat/tests~~ feat(ui-tests): scaffolds basic test Jan 12, 2024

vercel bot had a problem deploying to Preview January 12, 2024 13:35 Failure

vercel bot had a problem deploying to Preview January 12, 2024 13:42 Failure

arein requested a review from chris13524 January 12, 2024 13:43

arein force-pushed the feat/tests branch from fbfa237 to 6a7464f Compare January 12, 2024 14:03

vercel bot had a problem deploying to Preview January 12, 2024 14:04 Failure

arein requested a review from devceline January 12, 2024 14:14

vercel bot had a problem deploying to Preview January 12, 2024 14:15 Failure

vercel bot had a problem deploying to Preview January 15, 2024 11:04 Failure

arein force-pushed the feat/tests branch from bf50f3a to d899a8f Compare January 15, 2024 11:09

vercel bot had a problem deploying to Preview January 15, 2024 11:11 Failure

vercel bot had a problem deploying to Preview January 15, 2024 11:25 Failure

vercel bot had a problem deploying to Preview January 15, 2024 11:51 Failure

vercel bot had a problem deploying to Preview January 15, 2024 12:03 Failure

chris13524 requested changes Jan 15, 2024

View reviewed changes

arein requested a review from chris13524 January 15, 2024 13:51

vercel bot had a problem deploying to Preview January 15, 2024 13:52 Failure

vercel bot had a problem deploying to Preview January 15, 2024 13:56 Failure

arein force-pushed the feat/tests branch from bd90819 to 581879e Compare January 18, 2024 04:59

vercel bot had a problem deploying to Preview January 18, 2024 05:00 Failure

arein added 2 commits January 18, 2024 06:05

feat(ui-tests): scaffolds basic test

93fe4cc

feat: tests

0d678fd

arein added 10 commits January 18, 2024 06:05

feat: tests

5bafc9a

feat: tests

b32846f

feat: tests

1ff8bc7

feat: tests

b0e8025

feat: tests

7f58493

feat: tests

48b54a9

feat: tests

67cd9d8

chore: udpdate dependencies

bc92ed9

feat: improve speed

8eb4c8b

feat: reset yarn

19ef7dd

arein force-pushed the feat/tests branch from 581879e to 19ef7dd Compare January 18, 2024 11:08

vercel bot deployed to Preview January 18, 2024 11:09 View deployment

vercel bot deployed to Preview January 18, 2024 11:55 View deployment

chore: remove dotenv

a9af335

vercel bot deployed to Preview January 18, 2024 11:57 View deployment

chris13524 approved these changes Jan 18, 2024

View reviewed changes

chore: fix yarn lock in tests (#414)

46ddb77

vercel bot deployed to Preview January 18, 2024 13:10 View deployment

arein merged commit 663184c into main Jan 18, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui-tests): scaffolds basic test #388

feat(ui-tests): scaffolds basic test #388

arein commented Jan 12, 2024 •

edited

Loading

vercel bot commented Jan 12, 2024 •

edited

Loading

chris13524 left a comment

chris13524 Jan 15, 2024

arein commented Jan 15, 2024

arein commented Jan 15, 2024

chris13524 commented Jan 15, 2024

enesozturk commented Jan 18, 2024

arein commented Jan 18, 2024

chris13524 left a comment

chris13524 Jan 18, 2024

chris13524 Jan 18, 2024

chris13524 Jan 18, 2024


		import { BASE_URL } from '../constants'

		export class ModalPage {

feat(ui-tests): scaffolds basic test #388

feat(ui-tests): scaffolds basic test #388

Conversation

arein commented Jan 12, 2024 • edited Loading

Description

Type of change

Fixes/Resolves (Optional)

Examples/Screenshots (Optional)

Checklist:

Additional Information (Optional)

vercel bot commented Jan 12, 2024 • edited Loading

chris13524 left a comment

Choose a reason for hiding this comment

chris13524 Jan 15, 2024

Choose a reason for hiding this comment

arein commented Jan 15, 2024

arein commented Jan 15, 2024

src/components/settings/PrivacySettings/index.tsx(44,10): error TS2741: Property 'children' is missing in type '{ title: string; subtitle: string; }' but required in type 'IProps'.

chris13524 commented Jan 15, 2024

enesozturk commented Jan 18, 2024

arein commented Jan 18, 2024

chris13524 left a comment

Choose a reason for hiding this comment

chris13524 Jan 18, 2024

Choose a reason for hiding this comment

chris13524 Jan 18, 2024

Choose a reason for hiding this comment

chris13524 Jan 18, 2024

Choose a reason for hiding this comment

arein commented Jan 12, 2024 •

edited

Loading

vercel bot commented Jan 12, 2024 •

edited

Loading