refactor: move the subscription complete handler on useEffect #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
commented
Jan 13, 2024
| @@ -99,6 +93,12 @@ const AppCard: React.FC<AppCardProps> = ({ | |||
| } | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| if (subscribing && subscribed) { | |||
| showSuccessMessageToast(`Subscribed to ${name}`) | |||
There was a problem hiding this comment.
@devceline Should we call the setSubscribing(false) in this block as well? Seems like we don't set it to false if no error occurs.
There was a problem hiding this comment.
I don't think it matters because subscribed would be true
There was a problem hiding this comment.
Lets double make sure it's not gonna retriggered
devceline
approved these changes
Jan 13, 2024
| @@ -99,6 +93,12 @@ const AppCard: React.FC<AppCardProps> = ({ | |||
| } | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| if (subscribing && subscribed) { | |||
| showSuccessMessageToast(`Subscribed to ${name}`) | |||
There was a problem hiding this comment.
I don't think it matters because subscribed would be true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we're calling the
handleSubmitat once and thesubscribedandsubscribingvalues changing over time. We should watch these values inuseEffectto handle subscribed state and take action (like show a toast message).Type of change
Fixes/Resolves (Optional)
Closes https://github.com/WalletConnect/web3inbox-planning/issues/51
Examples/Screenshots (Optional)
Screen.Recording.2024-01-13.at.17.20.25.mov
Checklist: