feat: add change browser modal #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I tested on chrome on desktop, set to the pixel 7, but didn't see the screen as expected 
|
chadyj
approved these changes
Jan 15, 2024
devceline
reviewed
Jan 15, 2024
src/utils/pwa.ts
Outdated
| export const isIOS = () => /iPhone|iPad|iPod/i.test(navigator.userAgent) | ||
|
|
||
| export const isChrome = () => | ||
| browser?.name ? /chrome|crios|edge-chromium/i.test(browser?.name) : false |
There was a problem hiding this comment.
Should we cover brave here?
devceline
requested changes
Jan 15, 2024
enesozturk
force-pushed
the
feat/change-browser-modal
branch
from
3948c31 to
d541c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iOS Chromium browsers don't have
Add to Home Screenfunctionality. For the iOS users, we should redirect them to Safari instead. Added change browser modal and refactored conditions for the other modals to make sure that mobile Chroimum users should redirected to Safari first.Type of change
Fixes/Resolves (Optional)
Examples/Screenshots (Optional)
Checklist:
Additional Information (Optional)
Closes https://github.com/WalletConnect/web3inbox-planning/issues/48