Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: open support links in new tab #404

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jan 15, 2024

Description

Update support page links to open them in a new tab

Type of change

  • Refactor (non-breaking change which fixes an issue)

Fixes/Resolves (Optional)

Closes https://github.com/WalletConnect/web3inbox-planning/issues/52
Closes https://github.com/WalletConnect/www-web3inbox/issues/11

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@enesozturk enesozturk requested a review from devceline January 15, 2024 15:10
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 3:38pm

Copy link
Contributor

@chadyj chadyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the preview link 👍

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enesozturk enesozturk merged commit c273227 into main Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants