fix: ensure useEffect does not spam closeWeb3Modal + close event

[bkrem]

Description

• Bug: This useEffect is called in a loop for the duration of the signature modal being open
  • It was also calling closeWeb3Modal unchecked i.e. even if w3m was already in a closed state
  • This was causing our analytics endpoint to be spammed with MODAL_CLOSE events which could lead to unintentional request floods from users that leave the app in this state.
• This patch ensures we first check open: boolean state for w3m before explicitly calling closeWeb3Modal
• This patch does not root cause why this useEffect goes into a loop once the signature modal opens, this is TBD.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Examples/Screenshots (Optional)

Reproduction

1. Go to app.web3inbox.com (or a preview that has w3m analytics enabled)
2. Use a fresh account or reset client state to ensure you get the secondary "Sign notify message" popup after w3m connect
3. Observe network tab after initial w3m connect; spamming the pulse.walletconnect.com/e endpoint with MODAL_CLOSE events (see screenshot)

Screenshots

Checklist:

• I have performed a self-review of my own code
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-web3inbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 16, 2024 11:30am

[devceline]

It looks good to me bar the Notification access

[devceline]

LGTM