Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update layout styles #408

Merged

Conversation

enesozturk
Copy link
Contributor

Description

Refactor layout styles that the current styling solution doesn't provide a flexibility for the banner and the main layout shifted out the screen.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Fixes/Resolves (Optional)

Fixes https://github.com/WalletConnect/web3inbox-planning/issues/56#issuecomment-1893924547

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@enesozturk enesozturk requested a review from devceline January 16, 2024 16:41
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview Jan 16, 2024 4:42pm

Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did a quick run through on desktop preview and as a PWA on my iPhone and couldn't see any noticeable regressions visually.

Vertical displacement from the banner seems to be fixed 👍

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enesozturk enesozturk merged commit f9c1840 into main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants