Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump notify 0 16 5 #418

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Chore/bump notify 0 16 5 #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3a4cc
chore: bump notify client 0.16.5
devceline Jan 25, 2024
30e5741
chore: fix type annotation
devceline Jan 25, 2024
98df17b
chore: change undefined to null
devceline Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@sentry/react": "^7.93.0",
"@walletconnect/core": "2.11.0",
"@walletconnect/identity-keys": "^1.0.1",
"@walletconnect/notify-client": "^0.16.4",
"@walletconnect/notify-client": "^0.16.5",
"@walletconnect/notify-message-decrypter": "^0.1.0",
"@web3modal/wagmi": "3.5.6",
"classnames": "^2.3.2",
Expand Down
4 changes: 2 additions & 2 deletions src/components/notifications/AppNotifications/AppNotificationItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface IAppNotification {
message: string
isRead: boolean
timestamp: number
url?: string
url: string | null
}
interface IAppNotificationProps {
notification: IAppNotification
Expand All @@ -30,7 +30,7 @@ interface IAppNotificationProps {

const AppNotificationItemLink: React.FC<{
children: React.ReactNode
url?: string
url: string | null
className?: string
}> = ({ children, url, ...props }) => {
if (!url) return <div {...props}>{children}</div>
Expand Down
6 changes: 3 additions & 3 deletions src/reducers/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { NotifyClientTypes } from '@walletconnect/notify-client'

export interface TopicNotificationsState {
fullNotifications: NotifyClientTypes.NotifyMessage[]
fullNotifications: NotifyClientTypes.NotifyNotification[]
existingIds: Set<string>
hasMore: boolean
}
Expand All @@ -13,13 +13,13 @@ export interface NotificationsState {
export type NotificationsActions =
| {
type: 'FETCH_NOTIFICATIONS'
notifications: NotifyClientTypes.NotifyMessage[]
notifications: NotifyClientTypes.NotifyNotification[]
topic: string
hasMore: boolean
}
| {
type: 'UNSHIFT_NEW_NOTIFICATIONS'
notifications: NotifyClientTypes.NotifyMessage[]
notifications: NotifyClientTypes.NotifyNotification[]
topic: string
}

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3416,10 +3416,10 @@
"@walletconnect/modal-core" "2.6.2"
"@walletconnect/modal-ui" "2.6.2"

"@walletconnect/notify-client@^0.16.4":
version "0.16.4"
resolved "https://registry.yarnpkg.com/@walletconnect/notify-client/-/notify-client-0.16.4.tgz#d2f1b55867cbd9793a6dee5c1e4554ad48055af3"
integrity sha512-+Y4CRG//oYTd3fB4qRnCyGx8TFv1+b5lW0LHCD8t/X+fS3rU7A03VPRoJgJwedrmyhjWh1Leh3VnXinCtTSNHw==
"@walletconnect/notify-client@^0.16.5":
version "0.16.5"
resolved "https://registry.yarnpkg.com/@walletconnect/notify-client/-/notify-client-0.16.5.tgz#17605e6ff44a5d59e7a2cc2b515309af51a736d0"
integrity sha512-u0oJYlRmBHW6KiFLyAvpzyKq3ZDwkeK5tuYSy9HQOG+bFYxAyIJ7O0HUpCbojhq+aRFzPAP5FeNUXkhKxvPGPA==
dependencies:
"@noble/ed25519" "^1.7.3"
"@walletconnect/cacao" "1.0.2"
Expand Down
Loading