Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: losslessly compress all img assets #420

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Jan 26, 2024

Description

Vercel bandwidth is our friend :)

Vercel bandwidth is our friend :)
@bkrem bkrem requested review from enesozturk and devceline January 26, 2024 12:43
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview Jan 26, 2024 0:43am

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should've done this a while ago

@enesozturk
Copy link
Contributor

@bkrem @devceline Seems like most of these icons are not used, high possibly they belongs to previous chat application, what about removing them?

If we don't have a plan in the near future to build chat experience, we could remove the chat code along with the assets. That would be better, I could handle this, wdyt?

@chris13524
Copy link
Member

Should we merge this? Also using Git LFS would be nice.

Re: chat, we don't have plans for the next several months but we may revisit it. I suppose it would be fine to remove it all for now though as we will still have the code in Git history.

@enesozturk
Copy link
Contributor

@bkrem This looks good to me, I'm merging it. Thanks 🙌

@chris13524 totally, I think we should get rid of it until have a stable plan. Too much things to refactor and remove in this codebase. Let's keep it as minimal as possible.

@enesozturk enesozturk merged commit 393c689 into main Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants