Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/use recaps #557

Merged
merged 37 commits into from
May 27, 2024
Merged

Feat/use recaps #557

merged 37 commits into from
May 27, 2024

Conversation

devceline
Copy link
Collaborator

@devceline devceline commented Apr 22, 2024 •
edited
Loading

Note

Dependent on WalletConnect/web3inbox-client#87

Description

  • Run prettier
  • Remove signature modal
  • Use web3modal SIWE as an alternative to the above
  • Enable one click auth

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Fixes/Resolves (Optional)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel Vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:50pm

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

@devceline devceline requested review from chris13524 and enesozturk May 6, 2024 10:53
@devceline devceline marked this pull request as ready for review May 6, 2024 10:54
chris13524
chris13524 reviewed May 6, 2024
View reviewed changes
src/utils/siwe.ts
} catch (e) {}

await client.register({
registerParams: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registerParams not being used as a black box anymore? Why is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we need to combine params coming from the amended cacao from sign 2.5 with our register params

@devceline devceline merged commit 7c55cb2 into main May 27, 2024
3 checks passed
@devceline devceline deleted the feat/use-recaps branch May 27, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@enesozturk enesozturk Awaiting requested review from enesozturk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use recaps to sign in
2 participants
@devceline @chris13524