Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing cases hang #561

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: failing cases hang #561

merged 1 commit into from
May 8, 2024

Conversation

chris13524
Copy link
Member

Seems like when a test fails it hangs the ECS task and doesn't exist. Setting CI=true will prevent this. Slack conversation

@chris13524 chris13524 requested a review from devceline May 8, 2024 14:24
@chris13524 chris13524 self-assigned this May 8, 2024
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:24pm

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris13524 chris13524 merged commit d3b3b62 into main May 8, 2024
3 checks passed
@chris13524 chris13524 deleted the fix/failing-cases-hang branch May 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants