-
Notifications
You must be signed in to change notification settings - Fork 104
docs: add security and polkadot chain support pages #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
2
commits into
main
Choose a base branch
from
devin/1770734940-add-walletkit-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,311 @@ | ||
| --- | ||
| title: "Polkadot" | ||
| description: "Integrate WalletConnect into Polkadot wallets using the Wallet SDK, including session management, signing, and namespace configuration." | ||
| sidebarTitle: "Polkadot" | ||
| --- | ||
|
|
||
| This guide covers integrating the WalletConnect Wallet SDK into Polkadot-based wallets, including session proposals, request handling, and namespace configuration. | ||
|
|
||
| ## Wallet Integration Guide | ||
|
|
||
| ### Getting Started | ||
|
|
||
| Generate a unique `projectId` by visiting and creating your project's profile on the WalletConnect Dashboard at [dashboard.walletconnect.com](https://dashboard.walletconnect.com/). | ||
|
|
||
| ### Setup | ||
|
|
||
| Import Core and Wallet SDK from WalletConnect. | ||
|
|
||
| ```js | ||
| import { Core } from "@walletconnect/core"; | ||
| import { WalletKit } from "@walletconnect/walletkit"; | ||
| ``` | ||
|
|
||
| Instantiate and add Core and Wallet SDK to the state of the wallet. | ||
|
|
||
| ```js | ||
| const core = new Core({ projectId: "YOUR_PROJECT_ID" }); | ||
| const walletKit = await WalletKit.init({ | ||
| core: core, | ||
| metadata: { | ||
| name: "Example WalletConnect Wallet", | ||
| description: "Example WalletConnect Integration", | ||
| url: "myexamplewallet.com", | ||
| icons: [], | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
| Create a function to accept a session `uri` which will be passed from a dapp when a user either scans the dapp's WalletConnect QR code modal or manually copies and pastes the URI from the modal into the wallet's UI. | ||
|
|
||
| ```js | ||
| const onConnect = async (uri: string) => { | ||
| const result = await walletKit.core.pairing.pair({ uri }); | ||
| }; | ||
| ``` | ||
|
|
||
| Handle the `session_proposal` event on the `walletKit`. This event is triggered when the `pair` method is called on `walletKit.core.pairing` to create a pairing session. | ||
|
|
||
| ### Approving a Session Proposal | ||
|
|
||
| When approving a session proposal, the wallet can perform any necessary checks such as ensuring that the proposal includes all required namespaces and any optional namespaces. The approval response also contains the approved accounts as part of the namespace. | ||
|
|
||
| ```js | ||
| const substrateAccounts = [ | ||
| "5CK8D1sKNwF473wbuBP6NuhQfPaWUetNsWUNAAzVwTfxqjfr", | ||
| "5F3sa2TJAWMqDhXG6jhV4N8ko9SxwGy8TpaNS1repo5EYjQX", | ||
| ]; | ||
|
|
||
| const walletConnectAccounts = accounts.map( | ||
| (account) => `polkadot:91b171bb158e2d3848fa23a9f1c25182:${account.address}` | ||
| ); | ||
|
|
||
| walletKit.on("session_proposal", async (proposal) => { | ||
| showWalletConnectModal(); | ||
|
|
||
| const session = await walletKit.approveSession({ | ||
| id: proposal.id, | ||
| namespaces: { | ||
| polkadot: { | ||
| accounts: walletConnectAccounts, | ||
| methods: ["polkadot_signTransaction", "polkadot_signMessage"], | ||
| chains: ["polkadot:91b171bb158e2d3848fa23a9f1c25182"], | ||
| events: ["chainChanged", "accountsChanged"], | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const response = { | ||
| id: proposal.id, | ||
| result: "session approved", | ||
| jsonrpc: "2.0", | ||
| }; | ||
|
|
||
| await walletKit.respondSessionRequest({ topic: session.topic, response }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Rejecting a Session Proposal | ||
|
|
||
| If the user does not approve the requested chains, methods, or accounts, or if the wallet does not support the requested chains or methods, the response should not be considered a success. | ||
|
|
||
| ```js | ||
| import { getSdkError } from "@walletconnect/utils"; | ||
|
|
||
| walletKit.on("session_proposal", async (proposal) => { | ||
| showWalletConnectModal(); | ||
|
|
||
| await walletKit.rejectSession({ | ||
| id: proposal.id, | ||
| reason: getSdkError("USER_REJECTED"), | ||
| }); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Handling Session Request Events | ||
|
|
||
| A dapp triggers an event when it requires the wallet to carry out a specific action, such as signing a transaction. The event includes a topic and a request object, which will differ based on the requested action. Two common use cases in Polkadot are signing messages and signing transactions, represented as `polkadot_signMessage` and `polkadot_signTransaction` respectively. | ||
|
|
||
| ```js | ||
| walletKit.on("session_request", async (requestEvent) => { | ||
| const { params, id } = requestEvent; | ||
| const { request } = params; | ||
| const address = request.params?.address; | ||
|
|
||
| const wallet = getPolkadotWallet(address); | ||
|
|
||
| if (!wallet) { | ||
| throw new Error("Polkadot wallet does not exist"); | ||
| } | ||
|
|
||
| switch (request.method) { | ||
| case "polkadot_signMessage": | ||
| const msgSignature = await wallet.signMessage(request.params.message); | ||
| const msgResponse = { id, result: { signature: msgSignature }, jsonrpc: "2.0" }; | ||
| await walletKit.respondSessionRequest({ topic, response: msgResponse }); | ||
| break; | ||
|
|
||
| case "polkadot_signTransaction": | ||
| const txSignature = await wallet.signTransaction( | ||
| request.params.transactionPayload | ||
| ); | ||
| const txResponse = { id, result: { signature: txSignature }, jsonrpc: "2.0" }; | ||
| await walletKit.respondSessionRequest({ topic, response: txResponse }); | ||
| break; | ||
|
|
||
| default: | ||
| throw new Error(getSdkError("INVALID_METHOD").message); | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| ### Session Persistence and Management | ||
|
|
||
| - Sessions can be saved/stored so users don't have to pair repeatedly. | ||
| - Sessions can be disconnected using `await walletKit.disconnectSession({ topic: topic });`. | ||
| - Sessions can be extended using `await walletKit.extendSession({ topic: topic });`. | ||
| - Default session lifetime is 7 days for WalletConnect v2.0. | ||
|
|
||
| ## Namespaces Guide | ||
|
|
||
| ### Understanding Namespaces | ||
|
|
||
| Pairing sessions use specific methods, events, and chains during their lifetimes. These arguments constitute what is known as a `namespace`. Namespaces are used to specify the chains, methods, and events that are intended to be used in a particular session. They establish the minimal requirement for a wallet and a dapp to get paired. There are two types of namespaces: `proposal namespaces` and `session namespaces`. | ||
|
|
||
| ### Proposal Namespaces | ||
|
|
||
| A dapp sends a proposal namespace to the wallet for pairing. The proposal namespace contains the list of `chains`, `methods`, and `events` that the dapp intends to make use of. The wallet validates if the received proposal namespaces are valid and returns a session with its approved namespaces as a response. | ||
|
|
||
| Example Proposal Namespace for a dapp which supports connecting to Polkadot, Ethereum, Polygon, and Cosmos: | ||
|
|
||
| ```js | ||
| { | ||
| "polkadot": { | ||
| "chains": [ | ||
| "polkadot:91b171bb158e2d3848fa23a9f1c25182", | ||
| "polkadot:b0a8d493285c2df73290dfb7e61f870f", | ||
| ], | ||
| "methods": ["polkadot_signMessage"], | ||
| "events": ["accountsChanged"] | ||
| }, | ||
| "eip155": { | ||
| "chains": [ | ||
| "eip155:1", | ||
| "eip155:137" | ||
| ], | ||
| "methods": ["eth_sign"], | ||
| "events": ["accountsChanged"] | ||
| }, | ||
| "cosmos": { | ||
| "chains": ["cosmos:cosmoshub-4"], | ||
| "methods": ["cosmos_signDirect"], | ||
| "events": ["someCosmosEvent"] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Session Namespaces | ||
|
|
||
| The wallet validates if the received proposal namespaces match with the session namespaces it supports. The wallet session can also choose to provide access to more chains, methods, or events that were not a part of the proposal namespaces. | ||
|
|
||
| ```js | ||
| { | ||
| "polkadot": { | ||
| "accounts": [ | ||
| "polkadot:91b171bb158e2d3848fa23a9f1c25182:AZBEwbZhYeiofodZnM2iAoshP3pXRPNSJEKFqEPDmvv1mY7" | ||
| ], | ||
| "methods": ["polkadot_signMessage", "polkadot_signTransaction"], | ||
| "events": ["accountsChanged"] | ||
| }, | ||
| "eip155": { | ||
| "accounts": [ | ||
| "eip155:137:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb", | ||
| "eip155:1:0xab16a96d359ec26a11e2c2b3d8f8b8942d5bfcdb" | ||
| ], | ||
| "methods": ["eth_sign"], | ||
| "events": ["accountsChanged"] | ||
| }, | ||
| "cosmos": { | ||
| "accounts": [ | ||
| "cosmos:cosmoshub-4:cosmos1t2uflqwqe0fsj0shcfkrvpukewcw40yjj6hdc0" | ||
| ], | ||
| "methods": ["cosmos_signDirect", "personal_sign"], | ||
| "events": ["someCosmosEvent", "proofFinalized"] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Chains | ||
|
|
||
| `chains` is an array of chain IDs which represent the chains the session will be using during its lifetime. For Polkadot, the format for each chain ID is the chain-agnostic namespace (e.g. `polkadot`, `eip155`, `cosmos`) followed by a colon and the genesis hash for the chain (e.g. `91b171bb158e2d3848fa23a9f1c25182` for Polkadot). | ||
|
|
||
| ### Methods | ||
|
|
||
| `methods` is represented as an array of wallet-defined methods that a session supports. These are not pre-defined or centrally implemented and can be modified/extended as needed by a wallet. | ||
|
|
||
| In the above Polkadot session namespace example there are two given methods: `polkadot_signMessage` and `polkadot_signTransaction`. [An example for each method](https://github.com/WalletConnect/web-examples/blob/main/advanced/wallets/react-wallet-v2/src/lib/PolkadotLib.ts). | ||
|
|
||
| Wallets can also define additional methods. For example, adding a `polkadot_getSignedHex` method: | ||
|
|
||
| ```js | ||
| { | ||
| "polkadot": { | ||
| "accounts": [ | ||
| "polkadot:91b171bb158e2d3848fa23a9f1c25182:AZBEwbZhYeiofodZnM2iAoshP3pXRPNSJEKFqEPDmvv1mY7" | ||
| ], | ||
| "methods": [ | ||
| "polkadot_signMessage", | ||
| "polkadot_signTransaction", | ||
| "polkadot_getSignedHex" | ||
| ], | ||
| "events": ["accountsChanged"] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Events | ||
|
|
||
| `events` represent specific changes in a session's state that a dapp or wallet may want to take action on. For example, emitting an `accountsChanged` event: | ||
|
|
||
| ```js | ||
| await signClient.emit({ | ||
| topic, | ||
| event: { | ||
| name: "accountsChanged", | ||
| data: ["AZBEwbZhYeiofodZnM2iAoshP3pXRPNSJEKFqEPDmvv1mY7"], | ||
| }, | ||
| chainId: "polkadot:91b171bb158e2d3848fa23a9f1c25182", | ||
| }); | ||
| ``` | ||
|
|
||
| ### Dapps: Universal Provider and Namespaces | ||
|
|
||
| The connect method on the universal provider expects an object that matches the `ConnectParams` interface: | ||
|
|
||
| ```js | ||
| interface ConnectParams { | ||
| requiredNamespaces?: ProposalTypes.RequiredNamespaces; | ||
| optionalNamespaces?: ProposalTypes.OptionalNamespaces; | ||
| sessionProperties?: ProposalTypes.SessionProperties; | ||
| pairingTopic?: string; | ||
| relays?: RelayerTypes.ProtocolOptions[]; | ||
| } | ||
| ``` | ||
|
|
||
| Example using only the `requiredNamespaces` field: | ||
|
|
||
| ```js | ||
| const proposalNamespace = { | ||
| requiredNamespaces: { | ||
| polkadot: { | ||
| methods: ["polkadot_signTransaction", "polkadot_signMessage"], | ||
| chains: ["polkadot:91b171bb158e2d3848fa23a9f1c25182"], | ||
| events: ["chainChanged", "accountsChanged"], | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const { uri, approval } = await provider.client.connect(proposalNamespace); | ||
| ``` | ||
|
|
||
| ### Wallets: Wallet SDK and Namespaces | ||
|
|
||
| When the Wallet SDK approves and creates a session, it must provide the session proposal `id` as well as the session `namespaces` which are approved for use in the session: | ||
|
|
||
| ```js | ||
| const session = await walletKit.approveSession({ | ||
| id: proposal.id, | ||
| namespaces: { | ||
| polkadot: { | ||
| accounts: [ | ||
| "polkadot:91b171bb158e2d3848fa23a9f1c25182:AZBEwbZhYeiofodZnM2iAoshP3pXRPNSJEKFqEPDmvv1mY7", | ||
| ], | ||
| methods: ["polkadot_signTransaction", "polkadot_signMessage"], | ||
| chains: ["polkadot:91b171bb158e2d3848fa23a9f1c25182"], | ||
| events: ["chainChanged", "accountsChanged"], | ||
| }, | ||
| }, | ||
| }); | ||
| ``` | ||
|
|
||
| More information on namespaces can be found in the [WalletConnect specification](https://docs.walletconnect.com/specs/clients/sign/namespaces#controller-side-validation-of-incoming-proposal-namespaces-wallet). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| title: "Security Information" | ||
| description: "Security architecture, audits, and encryption details for the WalletConnect Wallet SDK." | ||
| sidebarTitle: "Security" | ||
| --- | ||
|
|
||
| Security is a fundamental aspect of the WalletConnect architecture. The infrastructure has undergone multiple rounds of third-party security reviews, audits, penetration testing, and threat modeling to ensure the highest standards of protection. Security is viewed as a continuously evolving discipline, with regular system audits to identify and address potential vulnerabilities. | ||
|
|
||
| ## Wallet SDK | ||
|
|
||
| ### Architecture | ||
|
|
||
| The Wallet SDK provides an end-to-end encrypted solution for wallets to connect to applications and sign messages/transactions. As an open-source SDK, it supports multiple transport methods, from WebSockets to Universal Links. | ||
|
|
||
| ### Handshake & End-to-End Encryption | ||
|
|
||
| For a detailed overview of the handshake and end-to-end encryption protocol, refer to the [technical specification](https://specs.walletconnect.com/2.0/specs/clients/sign/session-proposal). | ||
|
|
||
| ### Audits | ||
|
|
||
| The Wallet SDK, including its encryption stack, was audited by Trail of Bits. The audit report is available [here](https://github.com/trailofbits/publications/blob/master/reviews/2023-03-walletconnectv2-securityreview.pdf). This comprehensive security review covered the source code and included a lightweight Threat Model covering upstream and downstream dependencies. The broader WalletConnect system underwent Threat Modeling by Spearbit. The threat model is available [here](https://drive.google.com/file/d/1QpPSLvCEMunaYHHBPN0g6kYd39uFxpPk/view). | ||
|
|
||
| ### Dependencies | ||
|
|
||
| The Wallet SDK's design philosophy prioritizes minimizing third-party dependencies to reduce the attack surface area. | ||
|
|
||
| ## Third-Party Reviews | ||
|
|
||
| The security infrastructure of WalletConnect has undergone multiple rounds of audits by independent security auditing firms, including Trail of Bits, Halborn, and Spearbit. | ||
|
|
||
| | Audit Scope | Auditor | Report | | ||
| | --- | --- | --- | | ||
| | WalletConnect Comprehensive Threat Model | Spearbit | [View Report](https://drive.google.com/file/d/1QpPSLvCEMunaYHHBPN0g6kYd39uFxpPk/view) | | ||
| | Wallet SDK Security Review & Lightweight Threat Model | Trail of Bits | [View Report](https://github.com/trailofbits/publications/blob/master/reviews/2023-03-walletconnectv2-securityreview.pdf) | | ||
|
|
||
| ## Bug Bounty Program | ||
|
|
||
| WalletConnect maintains an active bug bounty program to encourage security researchers to responsibly disclose vulnerabilities and help strengthen the systems. For more information, visit the [security page](https://walletconnect.network/security). | ||
|
|
||
| ## Get in Touch | ||
|
|
||
| For security-related inquiries, please visit the [security contact page](https://walletconnect.network/security). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind adding full integration guide for WalletKit here not just Poladot RPC reference as here?
https://docs.reown.com/advanced/multichain/rpc-reference/polkadot-rpc
WalletKit integration guides can be found here for all the platforms: https://test-walletconnect-devin-1770734940-add-walletkit-pages.mintlify.app/wallet-sdk/overview
chain-support section should keep just the RCP reference, following current docs structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — you're right, the chain-support section should follow the RPC reference pattern like the other chains. I've replaced the full integration guide with the Polkadot RPC reference content (
polkadot_signTransactionandpolkadot_signMessage) matching the structure of the existing EVM, Solana, etc. pages. See commit a35967d.