Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety and Soundness #6

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Safety and Soundness #6

wants to merge 2 commits into from

Conversation

WanderLanz
Copy link
Owner

TLDR Working on some safety issues

  • pin peekable so that self-referential lends don't become dangling pointers on moves. (uncommon edge case, was previously overlooked)
  • simplify last and relax correctness of returned value
  • generate more tests to catch more edge cases

I don't know why the diff is so big

@vigna
Copy link
Collaborator

vigna commented Feb 17, 2024

Could you please try a cargo fmt?

@vigna
Copy link
Collaborator

vigna commented Feb 17, 2024

I don't know why the diff is so big

You saved all files with Windows end-of-line \r\n instead of \n.

@WanderLanz
Copy link
Owner Author

I love when git changes LF to CRLF without telling me 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants