Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced profiling instrumentation #3285

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

dkargin
Copy link
Contributor

@dkargin dkargin commented Jun 18, 2023

Introduced scope-based profiling instrumentation. Current instrumentation can use NVTX and/or VTune instrumentation.

@dkargin
Copy link
Contributor Author

dkargin commented Jul 8, 2023

This instrumentation allows to inspect performance profile and get detailed view for most of application activities:
Screenshot from 2023-07-08 12-40-58

By default profiling instrumentation is turned off and not causing much overhead (about ~1000 cycles per scope invocation).

@dkargin dkargin marked this pull request as ready for review July 8, 2023 09:45
@past-due past-due self-requested a review July 9, 2023 02:23
@past-due
Copy link
Member

past-due commented Jul 17, 2023

Looks like the main thing missing is adding the GPL preamble at the top of the new profiling.h and profiling.cpp files:

/*
	This file is part of Warzone 2100.
	Copyright (C) 2023  Warzone 2100 Project

	Warzone 2100 is free software; you can redistribute it and/or modify
	it under the terms of the GNU General Public License as published by
	the Free Software Foundation; either version 2 of the License, or
	(at your option) any later version.

	Warzone 2100 is distributed in the hope that it will be useful,
	but WITHOUT ANY WARRANTY; without even the implied warranty of
	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	GNU General Public License for more details.

	You should have received a copy of the GNU General Public License
	along with Warzone 2100; if not, write to the Free Software
	Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/

@past-due past-due added this to the 4.4.0-beta1 milestone Jul 18, 2023
@past-due past-due merged commit ba3ea74 into Warzone2100:master Jul 19, 2023
37 checks passed
@dkargin dkargin deleted the profiling branch July 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants