Prevent droids from ramming into targets when set to "Optimum Range" #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201 (hopefully)
This should stop units that are set to "Optimum Range" from continuing to approach their target until they literally ram into it.
Currently units set to optimum range that are between their short and long ranges (if their short range accuracy is greater) will constantly switch between DACTION_ATTACK and DACTION_MOVETOATTACK. If the unit happens to be in DACTION_ATTACK when it crosses the short range threshold, it won't recognize that it's close enough and continue to drive towards the target.
This PR makes it so that units set to optimum range will stay in DACTION_MOVETOATTACK while moving closer and firing, and correctly stop moving and switch to DACTION_ATTACK when entering their preferred range.
This seems to fix the issue without causing any unintentional effects, but more testing is always appreciated.