pointlight: Implement point light. #3580

vlj · 2023-12-30T22:42:12Z

This PR adds point lights support to OpenGL and Vulkan backend for terrain high settings and instanced lit object.

Description

This adds support for per pixel (not lightmap based) point lights that behaves "correctly" with normal data in the scene.

This is a rough implementation of the "Clustered Forward Shading" technic used in forward renderer like warzone renderer.
The idea is to split the view frustrum in small bucket and build for every bucket a list of all lights intersecting this bucket. Then in the fragment shaders, the fragment will query the right bucket depending on the screenspace location.

The assumption is that point lights are often very local, and thus it doesn't make sense to run the light computations on all visible lights for every pixel in the scene.

Due to the demanding nature of the technic it is enabled only for instanced meshes rendering and high details terrain.

For now there is a limit of 128 different "frame" lights, and the accumulated size of bucket light is 512, and there are 64 buckets.

Help needed

Coding

I don't know how to handle settings menu. I created 2 lightManagers, a "legacy" one that rely on lightmap like before and a "new" one that do the frustum calculations for consumption by the terrain_combined_high pipeline and the tcmask_instanced pipeline.
I have trouble with the CI, it looks like some builders don't see that I added an extra shader file for vulkan, and I don't know how to fix this atm.

Testing

The best map for quick test is the beginning of the beta campaign, with a lot of lights. Note that the first time when the VTOL are bombing the base in this mission, some point light disappear for a brief moment due to the amount of light.

After a toggle is introduced in the settings menu (currently I only tested by recompilation), I need tests to see if the legacy codepath still works.
I need tests to see if it works on various config, with and without the toggle enabled.

Screenshots

vlj · 2023-12-30T23:55:05Z

lib/framework/string_ext.h

@@ -46,8 +46,8 @@
 #	endif
 #	if defined(DEBUG)
 #		define strdup(s) \
-	strdup2(s,__FILE__,__LINE__)
-static inline char *strdup2(const char *s, char *fileName, int line)
+	strdup2(static_cast<const char*>(s),__LINE__)


when changing the C++ version of the standard, I discovered that it didn't compile (because type is const char[] vs const char* or something), I reverted back to C++14 but I think this is a safe change

src/input/context.h

vlj · 2023-12-30T23:56:32Z

lib/wzmaplib/src/map_script.cpp

@@ -25,6 +25,7 @@
 #include <algorithm>
 #include <cinttypes>
 #include <limits>
+#include <cassert>


it didn't build in debug for me (we use assert in the code below)

vlj · 2023-12-30T23:57:10Z

lib/ivis_opengl/gfx_api.h

@@ -747,6 +753,13 @@ namespace gfx_api
 		float fogBegin;
 		float timeState; // graphicsCycle
 		int fogEnabled;
+		int viewportWidth;
+		int viewportheight;
+		float unused2;


I don't really know how to elegantly handle std140 layout, I added an extra padding.

vlj · 2023-12-31T01:21:57Z

lib/ivis_opengl/pielighting.h

+};
+
+
+struct LightMap


This was part of the MAP_TILE struct before, I extracted this part so that it's easier to determine what happens on the lightmap (and surprisingly, not a lot)

vlj · 2023-12-31T01:23:17Z

src/display3d.cpp

@@ -1351,6 +1357,10 @@ static void drawTiles(iView *player)
 	const Vector3f theSun = (viewMatrix * glm::vec4(getTheSun(), 0.f)).xyz();
 	pie_BeginLighting(theSun);

+	// Reset all lighting data
+	getCurrentLightingData().lights.clear();


Since lights have a lifetime of a single frame in warzone engine, I reset the lists of light at the beginning of a frame.

data/base/shaders/pointlights.frag

data/base/shaders/vk/pointlights.glsl

data/base/shaders/tcmask_instanced.frag

ManManson · 2023-12-31T11:56:50Z

data/base/shaders/vk/pointlights.glsl

@@ -0,0 +1,40 @@
+// See https://lisyarus.github.io/blog/graphics/2022/07/30/point-light-attenuation.html for explanation
+// we want something that looks somewhat physically correct, but must absolutely be 0 past range
+float pointLightEnergyAtPosition(vec3 position, vec3 pointLightWorldPosition, float range)


This pointLightEnergyAtPosition and processPointLight is copy-pasted in the data/base/shaders/pointlights.frag, is there a way to re-use the implementation?

Vulkan shaders (inside shaders/vk) are kept as separate files from the OpenGL shaders (inside shaders/), so in this case we want to maintain the pattern and keep them separate.

(Despite them both nominally using GLSL, the Vulkan shaders often have to diverge - and can take advantage of newer GLSL features - than the OpenGL shaders.)

Ah, OK. Let's keep them separate then.

lib/ivis_opengl/pielighting.cpp

lib/ivis_opengl/pielighting.h

src/display3d.cpp

vlj · 2024-01-01T15:23:03Z

src/lighting.cpp

@@ -380,26 +388,6 @@ void calcDroidIllumination(DROID *psDroid)
 	psDroid->illumination = retVal;
 }

-void doBuildingLights()


was not used

lib/ivis_opengl/culling.cpp

vlj commented Dec 30, 2023

View reviewed changes

src/input/context.h Outdated Show resolved Hide resolved

vlj commented Dec 30, 2023

View reviewed changes

vlj commented Dec 31, 2023

View reviewed changes

ManManson suggested changes Dec 31, 2023

View reviewed changes

vlj commented Jan 1, 2024

View reviewed changes

vlj marked this pull request as ready for review January 1, 2024 16:40

ManManson reviewed Jan 1, 2024

View reviewed changes

lib/ivis_opengl/culling.cpp Outdated Show resolved Hide resolved

vlj closed this Jan 6, 2024

vlj force-pushed the pointlights branch from 6a5c080 to 57d397b Compare January 6, 2024 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pointlight: Implement point light. #3580

pointlight: Implement point light. #3580

vlj commented Dec 30, 2023 •

edited

Loading

vlj Dec 30, 2023

vlj Dec 30, 2023

vlj Dec 30, 2023

vlj Dec 31, 2023

vlj Dec 31, 2023

ManManson Dec 31, 2023

past-due Dec 31, 2023 •

edited

Loading

ManManson Dec 31, 2023

vlj Jan 1, 2024

pointlight: Implement point light. #3580

pointlight: Implement point light. #3580

Conversation

vlj commented Dec 30, 2023 • edited Loading

Description

Help needed

Coding

Testing

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

past-due Dec 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vlj commented Dec 30, 2023 •

edited

Loading

past-due Dec 31, 2023 •

edited

Loading