Convert more C-style lists to std::list
#3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
…ctor`, respectively Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Replace while-based loops introduced by Warzone2100#3572 with `mutating_list_iterate`. Signed-off-by: Pavel Solodovnikov <[email protected]>
past-due
reviewed
Jan 7, 2024
Don't use `.at()` method, which performs additional bounds checking in cases where we know upfront that the element exists. Signed-off-by: Pavel Solodovnikov <[email protected]>
past-due
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces
apsProxDisp(PROXIMITY_DISPLAY) andapsMessages(MESSAGE) global lists to usestd::listcontainer instead of intrusive C-style linked lists.Also, removed redundant
psNextpointer fromFLAG_POSITIONstruct.asFeatureStatsglobal array was converted to usestd::vector.Tests: Campaign, Beta -> Gamma transition, load/save campaign games.