Fix issues in BoneCrusher AI #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few global variables were assigned as arrays but were being used as objects later on. Breaking saves. Various warnings like missing semicolons and variable redeclarations fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few global variables were assigned as arrays but were being used as objects later on. Breaking saves.
Various warnings like missing semicolons and variable redeclarations fixed.
Ultimately to ensure BoneCrusher is absolutely saveload safe it would need to just declare
vars at the root level and initialize what is necessary inside an init function. Much like what is done with libcampaign, Cobra, SemperFi, etc. It does have an init() function called through eventGameLoaded (which fires after saveload) so maybe for now it won't be a big deal. Perhaps when I or anyone feels like doing avartolet/constconversion process for BoneCrusher it would be a good time to do that.