Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search by author #3837

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Monsterovich
Copy link
Contributor

@Monsterovich Monsterovich commented Jun 4, 2024

@vaut
Copy link
Contributor

vaut commented Jun 4, 2024

Are there any plans to add other filters?
Screenshot from 2024-06-04 21-14-46

@Monsterovich
Copy link
Contributor Author

Monsterovich commented Jun 4, 2024

Are there any plans to add other filters?

I think we should stop at author for now, because the other fields besides the map name are not so necessary.

In addition, I am limited by the UI library capabilities, for filters on the screenshot normally we need to make new UI widgets (and there is no space for them too).

Also, I don't think some information, like the amount of oils for each player, is in the metadata and it should be calculated somehow.

@past-due
Copy link
Member

past-due commented Jun 5, 2024

Additional filters are something that probably needs to wait for a larger map browser UI refresh (and a new backing store). There simply isn't enough room or ability to adjust the current map browser UI as-is.

@KJeff01 KJeff01 added this to the 4.6.0 milestone Oct 2, 2024
@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants