Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to groups and UI #4016

Merged
merged 6 commits into from
Jul 28, 2024
Merged

Conversation

Monsterovich
Copy link
Contributor

@Monsterovich Monsterovich commented Jul 15, 2024

Summary of this PR:

  • The droid count is now refreshed immediately when units retreat for repair.
  • Added a display of the number of damaged units in the group that will return to it after repair. This is also important information. For example: sometimes you forget about damaged units and they just stay at HQ (forgot to build a repair facility, lost all repairing units, etc.).
  • Now a group of damaged units is not recovered until the units are fully repaired, as it was intended in the original PR. Exception: if you set their repair flag to "do or die".
  • Improved the display of unit count text inside the widget. The three digit number was exceeding the borders of the widget. Now all variations are displayed correctly.

screenshot

@Monsterovich Monsterovich changed the title Improvements to groups UI Improvements to groups and UI Jul 15, 2024
Comment on lines -836 to +837
psDroid->order.type != DORDER_RTB)
psDroid->order.type != DORDER_RTB &&
secondaryGetState(psDroid, DSO_REPAIR_LEVEL) == DSS_REPLEV_NEVER)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pastdue and I are uncertain about the purpose of this change. The intent for this if statement was to prevent a retreating unit, that was disturbed from rtr/rtb, forever having a red group number until fully repaired. Unless there is some specific behavior difference we aren't noticing.

Copy link
Contributor Author

@Monsterovich Monsterovich Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KJeff01

forever having a red group number until fully repaired. Unless there is some specific behavior difference we aren't noticing.

This is only possible if there are no repair facilities or repairing units.

In the worst case, I'll just set a "do or die" flag on the units and just send them into battle, but it's too expensive to lose units. That's what alfred007 was talking about on Discord:

pic

The point is to keep as many units as possible, at the very least let them stand at the HQ with repair group set until I build repair facilities and send them to be repaired. Currently, the damaged units will just go into battle with low health which is worse.

Copy link
Contributor Author

@Monsterovich Monsterovich Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also an idea to make damaged units that stand at the HQ, automatically go to repair when at least one repair facility appears (I can do this, but it would be in a separate PR).

@past-due past-due added this to the 4.5.2 milestone Jul 28, 2024
@past-due past-due merged commit 5cde21c into Warzone2100:master Jul 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants