Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/wzmaplib: add missing <cstdint> includes #4060

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Sep 7, 2024

Without the change the build on upcoming gcc-15 fails as:

In file included from /build/warzone2100/lib/wzmaplib/src/map_script.cpp:20:
/build/warzone2100/lib/wzmaplib/src/map_script.h:31:97: error: 'uint32_t' has not been declared
   31 | std::shared_ptr<Map> runMapScript(const std::vector<char>& fileBuffer, const std::string &path, uint32_t seed, bool preview, LoggingProtocol* pCustomLogger = nullptr);
      |                                                                                                 ^~~~~~~~

Without the change the build on upcoming `gcc-15` fails as:

    In file included from /build/warzone2100/lib/wzmaplib/src/map_script.cpp:20:
    /build/warzone2100/lib/wzmaplib/src/map_script.h:31:97: error: 'uint32_t' has not been declared
       31 | std::shared_ptr<Map> runMapScript(const std::vector<char>& fileBuffer, const std::string &path, uint32_t seed, bool preview, LoggingProtocol* pCustomLogger = nullptr);
          |                                                                                                 ^~~~~~~~
@past-due past-due added this to the 4.5.3 milestone Sep 7, 2024
Copy link
Member

@past-due past-due left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - thank you!

@past-due past-due merged commit b2084bd into Warzone2100:master Sep 8, 2024
37 checks passed
@trofi trofi deleted the gcc-15-add-cstdint branch September 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants