-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PreSignURL method #255
base: master
Are you sure you want to change the base?
Commits on Mar 16, 2022
-
Add PreSignRequest to stow container
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9f205f - Browse repository at this point
Copy the full SHA f9f205fView commit details
Commits on Mar 17, 2022
-
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1190b61 - Browse repository at this point
Copy the full SHA 1190b61View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6548d4 - Browse repository at this point
Copy the full SHA b6548d4View commit details
Commits on Mar 23, 2022
-
Implement Presigned URL for Azure
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57524be - Browse repository at this point
Copy the full SHA 57524beView commit details -
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1ea081 - Browse repository at this point
Copy the full SHA e1ea081View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61cf833 - Browse repository at this point
Copy the full SHA 61cf833View commit details
Commits on Mar 26, 2022
-
Rename module to flyteorg/stow
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8e760b6 - Browse repository at this point
Copy the full SHA 8e760b6View commit details
Commits on Apr 7, 2022
-
Support ContentMD5 as an optional param
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d51bcb - Browse repository at this point
Copy the full SHA 0d51bcbView commit details -
Merge pull request #3 from flyteorg/rename
Rename module to flyteorg/stow
Configuration menu - View commit details
-
Copy full SHA for 8ee1921 - Browse repository at this point
Copy the full SHA 8ee1921View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9d38a1 - Browse repository at this point
Copy the full SHA b9d38a1View commit details -
Merge pull request #2 from flyteorg/content-md5
Support ContentMD5 as an optional param
Configuration menu - View commit details
-
Copy full SHA for 31630d5 - Browse repository at this point
Copy the full SHA 31630d5View commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cab99a8 - Browse repository at this point
Copy the full SHA cab99a8View commit details
Commits on Apr 13, 2022
-
Merge pull request #4 from flyteorg/upgrade-dependencies
Upgrade dependencies
Configuration menu - View commit details
-
Copy full SHA for 2a2e10f - Browse repository at this point
Copy the full SHA 2a2e10fView commit details
Commits on Apr 28, 2022
-
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 536e0c9 - Browse repository at this point
Copy the full SHA 536e0c9View commit details -
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9495372 - Browse repository at this point
Copy the full SHA 9495372View commit details -
Merge pull request #5 from flyteorg/gcp-presigned
Use latest google cloud lib
Configuration menu - View commit details
-
Copy full SHA for 9c3f5f9 - Browse repository at this point
Copy the full SHA 9c3f5f9View commit details
Commits on Jul 14, 2022
-
combine write and update to one request
Signed-off-by: Babis Kiosidis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6237dc1 - Browse repository at this point
Copy the full SHA 6237dc1View commit details
Commits on Jul 15, 2022
-
Merge pull request #6 from ckiosidis/avoid-double-write-to-gcs
combine write and update to one request
Configuration menu - View commit details
-
Copy full SHA for e9c5e6f - Browse repository at this point
Copy the full SHA e9c5e6fView commit details
Commits on Aug 1, 2023
-
adding sovereign cloud support
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0266c8e - Browse repository at this point
Copy the full SHA 0266c8eView commit details -
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a953565 - Browse repository at this point
Copy the full SHA a953565View commit details -
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1a6e32e - Browse repository at this point
Copy the full SHA 1a6e32eView commit details -
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54b0bc9 - Browse repository at this point
Copy the full SHA 54b0bc9View commit details -
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4dcff2 - Browse repository at this point
Copy the full SHA d4dcff2View commit details -
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78e3158 - Browse repository at this point
Copy the full SHA 78e3158View commit details
Commits on Aug 2, 2023
-
Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 52271ec - Browse repository at this point
Copy the full SHA 52271ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bd7f9a - Browse repository at this point
Copy the full SHA 6bd7f9aView commit details
Commits on Aug 22, 2023
-
Adds Azure sovereign cloud support to getSignedUrl (#8)
* adding baseUrl to get signed URl Signed-off-by: Gopal K. Vashishtha <[email protected]> * default correctly Signed-off-by: Gopal K. Vashishtha <[email protected]> * adding base url in Containers Signed-off-by: Gopal K. Vashishtha <[email protected]> * renaming Signed-off-by: Gopal K. Vashishtha <[email protected]> * Revert "renaming" This reverts commit 05c7cb3. Signed-off-by: Gopal K. Vashishtha <[email protected]> * renaming to non-exported function Signed-off-by: Gopal K. Vashishtha <[email protected]> --------- Signed-off-by: Gopal K. Vashishtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7a3695 - Browse repository at this point
Copy the full SHA c7a3695View commit details
Commits on Oct 19, 2023
-
Azure AD authentication support (and SDK upgrade) (#9)
* A refactor of the `azure` module to support authenticating via either Azure AD or shared keys. This required a larger-than-expected series of changes because the Azure SDK now very different than the one stow used before. This is an early commit to get changes out there for discussion. Included here is: - An upgrade of the Azure SDK used for the project (needed to support AD auth). This, unfortunately also brought in a whole series if indirect upgrades so testing will be needed. - Support for authenticating via either Azure AD or Shared keys - Removal of several azure config values (ConfigAPIVersion, ConfigUseHTTPS) and addition of ConfigUploadConcurrency. - Removal of the multi-part upload code for Azure, this is now included in the SDK - Addition of new presigned url tests into the general stow test/ module. - Addition of a new terraform module to stand up an azure storage account for testing. Signed-off-by: Terence Kent <[email protected]> * fix misspellings (doh) Signed-off-by: Terence Kent <[email protected]> * Update azure/config.go Accepting len(var)==0 vs var=="" Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Terence Kent <[email protected]> * Update azure/config.go Accepting improved error message Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Terence Kent <[email protected]> * Changes before moving PR from draft. No impact to tests or functionality at this point: - Removed all inline context.Background() calls when using Azure SDK methods. Now set an explicit `ctx` variable at the top of each function. - Added comments around the clock skew code, and moved all clock skews to 15 minutes (the azure-recommended value). Also left a comment explaining the decision. - Made the use of removed config values an error state for validation. Added a test to ensure this happens. - Moved some errant logging in the `checkMetadata` test method to only show up in inequality, to keep test output clean. Signed-off-by: Terence Kent <[email protected]> * Missed that the previous version of the Azure implementation silently ignored failures due to creating an already-existing container! The code from the old SDK to ignore "already exists" was preserved, but not working with the new SDK. - Updated the check to work with the new SDK. - Added a general test to confirm this behavior. Note: It's debatable if this should be the default behavior for all stow implementations. However, it seems like whatever the desired behavior is, it should be consistent across all implementations. Signed-off-by: Terence Kent <[email protected]> --------- Signed-off-by: Terence Kent <[email protected]> Co-authored-by: Terence Kent <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2b4d0dc - Browse repository at this point
Copy the full SHA 2b4d0dcView commit details
Commits on Oct 24, 2023
-
check for error before accessing s3 response (#10)
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d829e76 - Browse repository at this point
Copy the full SHA d829e76View commit details
Commits on Mar 5, 2024
-
Add extra header to signed url (#13)
* Add extra header to signed url Signed-off-by: Kevin Su <[email protected]> * make metadata optional Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * Add metadata to PresignRequestParams Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b497fb - Browse repository at this point
Copy the full SHA 9b497fbView commit details
Commits on Mar 11, 2024
-
PreSignRequest returns a PresignResponse instead (#14)
Signed-off-by: Kevin Su <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2912959 - Browse repository at this point
Copy the full SHA 2912959View commit details
Commits on Mar 12, 2024
-
Ensure that requestHeaders is correctly assigned a value (#15)
Signed-off-by: Kevin Su <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad68b70 - Browse repository at this point
Copy the full SHA ad68b70View commit details
Commits on Jul 25, 2024
-
Update azure sdk azblob 1.1.0 -> 1.4.0 / azcore 1.7.2 -> 1.13.0 (#16)
* Update azure sdk / mod tidy - Resolves vuln CVE-2024-35255 Signed-off-by: ddl-ebrown <[email protected]> * Fix test compile errors - These were caught by go vet. How does CI even run? Signed-off-by: ddl-ebrown <[email protected]> --------- Signed-off-by: ddl-ebrown <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 632adef - Browse repository at this point
Copy the full SHA 632adefView commit details