Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the version of wat dep #90

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

apepkuss
Copy link
Collaborator

In this PR, relax the version of wat dep to fix #88. In addition, the test cases affected by the change also get updated.

Copy link
Member

juntao commented Nov 14, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the Pull Request includes a variety of changes. Here are the most important findings:

  1. Relaxing the version of the wat dependency may introduce compatibility issues with the rest of the codebase or other dependencies. The rationale for this change should be provided to ensure it is intentional and necessary.

  2. The changes to the test code include new implementations and modifications in multiple files. It is important to ensure that the changes don't introduce potential bugs or performance issues. Additionally, the changes in some test files are marked with #[ignore], suggesting that the tests need updates. These updates should be made before merging the changes.

  3. The version bump of the wasmedge-sys crate and the update of the wasmedge-sdk version don't appear to have any potential problems.

Considering all the individual summaries, the most important finding is the potential compatibility issues that may arise from relaxing the version of the wat dependency. It is important to address this concern and provide a clear rationale for the change. Additionally, the changes in the test code need further review to ensure they don't introduce bugs or performance issues and that the tests are appropriately updated.

Details

Commit 0c0632321494f2eee1d745b0cbfd11dc1c9c2dd7

Key changes:

  • The version of the wat dependency has been relaxed from =1.0.67 to 1.0.

Potential problems:

  • Relaxing the version of a dependency may introduce compatibility issues with the rest of the codebase or other dependencies.
  • It's unclear why the version of the wat dependency is being relaxed. The rationale for this change should be provided to ensure it is intentional and necessary.

Additional notes:

  • The patch appears to update only the Cargo.toml file. No other files are modified.

Commit eed350a0fc3872512c2427ee157b9c22ad875f78

Key changes:

  • Updated the test code in compiler.rs and executor.rs. The code now includes a more complex Fibonacci function implementation.
  • Added additional functions and types to the module definition.

Potential problems:

  • The complexity of the new Fibonacci function implementation may introduce potential bugs or performance issues.
  • The new code does not include any tests or comments to explain its behavior.

Overall, the changes seem to be focused on improving the test code for the Rust SDK. However, without additional context or information, it is difficult to assess the impact and potential problems of these changes in the larger codebase.

Commit fd2abf93bd054ef1201419cc28e05844d4f09184

Summary of key changes:

  • Updated the test code in the ast_module.rs, compiler.rs, and statistics.rs files.
  • Added a new test case in ast_module.rs to test module import.
  • Updated the fibonacci test case in compiler.rs with a new WebAssembly code.

Potential problems:

  • The changes to the test code in ast_module.rs are marked with #[ignore], which suggests that the tests need updates. It is important to ensure that these tests are updated before merging the changes.
  • The changes to the test code in compiler.rs include modifications to the WebAssembly code. It is necessary to review and verify that the changes to the code produce the expected behavior.
  • The changes to the test code in statistics.rs are also marked with #[ignore], indicating that the test needs an update. It should be verified and updated before merging the changes.

Commit 1cb5a1da951acbd7100de75e498a2868b44006bb

Key changes:

  • The version of the wasmedge-sys crate has been bumped from 0.17.3 to 0.17.4 in the Cargo.toml file.

Potential problems:

  • There don't seem to be any potential problems with this patch from what is provided. It is a simple version bump.

Overall, this patch appears to be a straightforward update to the wasmedge-sys crate version.

Commit 01acb32aa97ba9772466a887edb1f682ed145308

Key changes:

  • Updated the version of wasmedge-sdk in Cargo.toml and README.md from 0.13.0 to 0.13.1.
  • Added the updated version to the table in README.md and commented out the previous version in src/lib.rs.

Potential problems:

  • There don't appear to be any potential problems with this patch. It simply updates the version of wasmedge-sdk to 0.13.1 in the relevant files.

Commit 2a177acc54b29c3f25dc961a4af1b9def1da20a9

Key changes:

Potential problems:

  • No potential problems identified.

@apepkuss apepkuss requested a review from hydai November 14, 2023 07:10
@apepkuss
Copy link
Collaborator Author

@hydai Could you please help review this PR? Thanks a lot!

@apepkuss
Copy link
Collaborator Author

@hydai Thanks for the review!

@apepkuss apepkuss merged commit c99e30d into WasmEdge:main Nov 14, 2023
34 checks passed
@apepkuss apepkuss mentioned this pull request Nov 16, 2023
apepkuss added a commit that referenced this pull request Nov 28, 2023
* [Refactor] Add #[form] for subtypes of WasmEdgeError.

Signed-off-by: csh <[email protected]>

* [Refactor] fix memory leak

Signed-off-by: csh <[email protected]>

* [Fix] Avoid the CPU 100% by tokio-wasi.

Signed-off-by: csh <[email protected]>

* [Fix] Fix blocking during tokio-wasi TCP connect.

Signed-off-by: csh <[email protected]>

* [Fix] async-wasi get envs & args

Signed-off-by: csh <[email protected]>

* [Perf] Optimize the wasi-ctx

Signed-off-by: csh <[email protected]>

* [Chore] Temporarily disable the serialize feature.

Signed-off-by: csh <[email protected]>

* [feat] virtual file system

Signed-off-by: csh <[email protected]>

* [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76)

* [Feat] run func timeout use std::time::Duration

Signed-off-by: csh <[email protected]>

* [Doc]: update api docs

Signed-off-by: csh <[email protected]>

---------

Signed-off-by: csh <[email protected]>
(cherry picked from commit 07e84b7)
Signed-off-by: csh <[email protected]>

* [Refactor] delete useless code from validator

Signed-off-by: csh <[email protected]>

* [Refactor] To pass the clippy

Signed-off-by: csh <[email protected]>

* Disable timeout in musl libc (#71)

Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: csh <[email protected]>

* Disable timeout in musl libc

Signed-off-by: csh <[email protected]>

* [Doc] update doc

Signed-off-by: csh <[email protected]>

* [Fix] fix ffi::WasmEdge_String to String

Signed-off-by: csh <[email protected]>

* [Fix] Fix unit test

Signed-off-by: csh <[email protected]>

* [Fix] Modify the `WasiModule`.

Signed-off-by: csh <[email protected]>

* [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84)

* feat(rust-sys): drop host_data in `Function::drop`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update `drop` of `ImportModule` and `Function`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update test code

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update `drop` of `ImportModule` and `Function`

Signed-off-by: Xin Liu <[email protected]>

* refactor(rust-sys): update `ImportModule::drop`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): remove debug code

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): remove debug code

Signed-off-by: Xin Liu <[email protected]>

* version(rust-sdk): bump to `0.13.0`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): supress clippy warning

Signed-off-by: Xin Liu <[email protected]>

* ci(ci-build): update rust version

Signed-off-by: Xin Liu <[email protected]>

* ci(standalone): update rust version

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update rustdoc

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update rustdoc and `README`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update dependencies

Signed-off-by: Xin Liu <[email protected]>

* ci: update to `macos-13`

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* doc: update `CHANGELOG` (#85)

Signed-off-by: Xin Liu <[email protected]>

* [Chore] Update build script (#86)

* chore(rust-sys): update build script

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update build script

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* [Fix] Fix sys test

Signed-off-by: csh <[email protected]>

* Relax the version of `wat` dep  (#90)

* chore(rust-sdk): update `wat` dep

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update test code

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update test code

Signed-off-by: Xin Liu <[email protected]>

* version(rust-sys): bump to `0.17.4`

Signed-off-by: Xin Liu <[email protected]>

* version(rust-sdk): bump to `0.13.1`

Signed-off-by: Xin Liu <[email protected]>

* doc: update `CHANGELOG`

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* [CI] skip test_vmbuilder on fedora

Signed-off-by: csh <[email protected]>

* Fix static build to link agains zstd (#91)

Signed-off-by: Jorge Prendes <[email protected]>

* Update doc for releasing `v0.13.2` (#93)

* ci: update workflows

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update versioning table

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): fix typo

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update rustdoc

Signed-off-by: Xin Liu <[email protected]>

* version(rust-sdk): bump to `0.13.2`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* [Version] Bump `wasmedge-sys` to `v0.17.5` (#94)

* version(rust-sys): bump to `0.17.5`

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update versioning table

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sys): update dependency

Signed-off-by: Xin Liu <[email protected]>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* doc: update `CHANGELOG` (#95)

Signed-off-by: Xin Liu <[email protected]>

* [CI] Update `rust-static-lib` workflow (#96)

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <[email protected]>

* ci(rust-static-lib): remove `libboost-all-dev` dep

Signed-off-by: Xin Liu <[email protected]>

---------

Signed-off-by: Xin Liu <[email protected]>

* [Fix] Temporary FuncRef extraction implementation.

Signed-off-by: csh <[email protected]>

* [CI] fix test wat

Signed-off-by: csh <[email protected]>

---------

Signed-off-by: csh <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Co-authored-by: Jorge Prendes <[email protected]>
Co-authored-by: Xin Liu <[email protected]>
@L-jasmine L-jasmine mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please bump wat to the newest version or relex the strict version requirement
3 participants