-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the version of wat
dep
#90
Conversation
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the Pull Request includes a variety of changes. Here are the most important findings:
Considering all the individual summaries, the most important finding is the potential compatibility issues that may arise from relaxing the version of the DetailsCommit 0c0632321494f2eee1d745b0cbfd11dc1c9c2dd7Key changes:
Potential problems:
Additional notes:
Commit eed350a0fc3872512c2427ee157b9c22ad875f78Key changes:
Potential problems:
Overall, the changes seem to be focused on improving the test code for the Rust SDK. However, without additional context or information, it is difficult to assess the impact and potential problems of these changes in the larger codebase. Commit fd2abf93bd054ef1201419cc28e05844d4f09184Summary of key changes:
Potential problems:
Commit 1cb5a1da951acbd7100de75e498a2868b44006bbKey changes:
Potential problems:
Overall, this patch appears to be a straightforward update to the Commit 01acb32aa97ba9772466a887edb1f682ed145308Key changes:
Potential problems:
Commit 2a177acc54b29c3f25dc961a4af1b9def1da20a9Key changes:
Potential problems:
|
@hydai Could you please help review this PR? Thanks a lot! |
@hydai Thanks for the review! |
* [Refactor] Add #[form] for subtypes of WasmEdgeError. Signed-off-by: csh <[email protected]> * [Refactor] fix memory leak Signed-off-by: csh <[email protected]> * [Fix] Avoid the CPU 100% by tokio-wasi. Signed-off-by: csh <[email protected]> * [Fix] Fix blocking during tokio-wasi TCP connect. Signed-off-by: csh <[email protected]> * [Fix] async-wasi get envs & args Signed-off-by: csh <[email protected]> * [Perf] Optimize the wasi-ctx Signed-off-by: csh <[email protected]> * [Chore] Temporarily disable the serialize feature. Signed-off-by: csh <[email protected]> * [feat] virtual file system Signed-off-by: csh <[email protected]> * [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76) * [Feat] run func timeout use std::time::Duration Signed-off-by: csh <[email protected]> * [Doc]: update api docs Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> (cherry picked from commit 07e84b7) Signed-off-by: csh <[email protected]> * [Refactor] delete useless code from validator Signed-off-by: csh <[email protected]> * [Refactor] To pass the clippy Signed-off-by: csh <[email protected]> * Disable timeout in musl libc (#71) Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: csh <[email protected]> * Disable timeout in musl libc Signed-off-by: csh <[email protected]> * [Doc] update doc Signed-off-by: csh <[email protected]> * [Fix] fix ffi::WasmEdge_String to String Signed-off-by: csh <[email protected]> * [Fix] Fix unit test Signed-off-by: csh <[email protected]> * [Fix] Modify the `WasiModule`. Signed-off-by: csh <[email protected]> * [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84) * feat(rust-sys): drop host_data in `Function::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * refactor(rust-sys): update `ImportModule::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): remove debug code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): remove debug code Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.0` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): supress clippy warning Signed-off-by: Xin Liu <[email protected]> * ci(ci-build): update rust version Signed-off-by: Xin Liu <[email protected]> * ci(standalone): update rust version Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update rustdoc and `README` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependencies Signed-off-by: Xin Liu <[email protected]> * ci: update to `macos-13` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#85) Signed-off-by: Xin Liu <[email protected]> * [Chore] Update build script (#86) * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Fix sys test Signed-off-by: csh <[email protected]> * Relax the version of `wat` dep (#90) * chore(rust-sdk): update `wat` dep Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update test code Signed-off-by: Xin Liu <[email protected]> * version(rust-sys): bump to `0.17.4` Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.1` Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [CI] skip test_vmbuilder on fedora Signed-off-by: csh <[email protected]> * Fix static build to link agains zstd (#91) Signed-off-by: Jorge Prendes <[email protected]> * Update doc for releasing `v0.13.2` (#93) * ci: update workflows Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): fix typo Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.2` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Version] Bump `wasmedge-sys` to `v0.17.5` (#94) * version(rust-sys): bump to `0.17.5` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependency Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#95) Signed-off-by: Xin Liu <[email protected]> * [CI] Update `rust-static-lib` workflow (#96) * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): remove `libboost-all-dev` dep Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Temporary FuncRef extraction implementation. Signed-off-by: csh <[email protected]> * [CI] fix test wat Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: Xin Liu <[email protected]> Co-authored-by: Jorge Prendes <[email protected]> Co-authored-by: Xin Liu <[email protected]>
In this PR, relax the version of
wat
dep to fix #88. In addition, the test cases affected by the change also get updated.