Fix static build to link agains zstd #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Prendes <[email protected]>
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit 034e9187da10f063ad6a2308ffbafde342482401Key changes in the patch:
Potential problems:
|
|
@Mossaka, this should fix the issues in containerd/runwasi#395 |
|
@apepkuss |
|
@jprendes wasmedge-sdk v0.13.2 and wasmedge-sys v0.17.5 have been released. Please check them out. Thanks! |
Merged
apepkuss
added a commit
that referenced
this pull request
Nov 28, 2023
* [Refactor] Add #[form] for subtypes of WasmEdgeError. Signed-off-by: csh <[email protected]> * [Refactor] fix memory leak Signed-off-by: csh <[email protected]> * [Fix] Avoid the CPU 100% by tokio-wasi. Signed-off-by: csh <[email protected]> * [Fix] Fix blocking during tokio-wasi TCP connect. Signed-off-by: csh <[email protected]> * [Fix] async-wasi get envs & args Signed-off-by: csh <[email protected]> * [Perf] Optimize the wasi-ctx Signed-off-by: csh <[email protected]> * [Chore] Temporarily disable the serialize feature. Signed-off-by: csh <[email protected]> * [feat] virtual file system Signed-off-by: csh <[email protected]> * [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76) * [Feat] run func timeout use std::time::Duration Signed-off-by: csh <[email protected]> * [Doc]: update api docs Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> (cherry picked from commit 07e84b7) Signed-off-by: csh <[email protected]> * [Refactor] delete useless code from validator Signed-off-by: csh <[email protected]> * [Refactor] To pass the clippy Signed-off-by: csh <[email protected]> * Disable timeout in musl libc (#71) Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: csh <[email protected]> * Disable timeout in musl libc Signed-off-by: csh <[email protected]> * [Doc] update doc Signed-off-by: csh <[email protected]> * [Fix] fix ffi::WasmEdge_String to String Signed-off-by: csh <[email protected]> * [Fix] Fix unit test Signed-off-by: csh <[email protected]> * [Fix] Modify the `WasiModule`. Signed-off-by: csh <[email protected]> * [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84) * feat(rust-sys): drop host_data in `Function::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * refactor(rust-sys): update `ImportModule::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): remove debug code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): remove debug code Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.0` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): supress clippy warning Signed-off-by: Xin Liu <[email protected]> * ci(ci-build): update rust version Signed-off-by: Xin Liu <[email protected]> * ci(standalone): update rust version Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update rustdoc and `README` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependencies Signed-off-by: Xin Liu <[email protected]> * ci: update to `macos-13` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#85) Signed-off-by: Xin Liu <[email protected]> * [Chore] Update build script (#86) * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Fix sys test Signed-off-by: csh <[email protected]> * Relax the version of `wat` dep (#90) * chore(rust-sdk): update `wat` dep Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update test code Signed-off-by: Xin Liu <[email protected]> * version(rust-sys): bump to `0.17.4` Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.1` Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [CI] skip test_vmbuilder on fedora Signed-off-by: csh <[email protected]> * Fix static build to link agains zstd (#91) Signed-off-by: Jorge Prendes <[email protected]> * Update doc for releasing `v0.13.2` (#93) * ci: update workflows Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): fix typo Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.2` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Version] Bump `wasmedge-sys` to `v0.17.5` (#94) * version(rust-sys): bump to `0.17.5` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependency Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#95) Signed-off-by: Xin Liu <[email protected]> * [CI] Update `rust-static-lib` workflow (#96) * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): remove `libboost-all-dev` dep Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Temporary FuncRef extraction implementation. Signed-off-by: csh <[email protected]> * [CI] fix test wat Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: Xin Liu <[email protected]> Co-authored-by: Jorge Prendes <[email protected]> Co-authored-by: Xin Liu <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like upstream WasmEdge has zstd as a new dependency.
This is not currently captured in the build script, which results in a linking error when using the
staticfeature.This PR also changes
wasmedge-sysminimum requirement from1.7to1.7.4sincewasmedge-sdkis not compatible withwasmedge-sys1.7.2(due to theu64->Durationchange in here)The missing dependency should have been captured by the
rust-static-libCI workflow, but it seems that workflow has never been triggered:https://github.com/WasmEdge/wasmedge-rust-sdk/actions/workflows/rust-static-lib.yml
This PR makes no attempt at resolving that.