-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc for releasing v0.13.2
#93
Conversation
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Signed-off-by: Xin Liu <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The first potential problem lies in the paths-ignore configuration of the rust-static-lib workflow. It is not clear why these specific paths are added and how they may impact the desired behavior of the workflow. The matrix configuration for the build_ubuntu job in the rust-static-lib workflow has been updated without stating the reasons for including specific Rust versions. Some context would be helpful to understand the motivation behind these changes. Another notable issue is a typo in the Furthermore, the flag Regarding the updates to the Overall, this pull request introduces various changes, with the most notable issues being the potential problems mentioned above. It is recommended that the author addresses these concerns and provides additional context where needed for better clarity and understanding. DetailsCommit 14614a0d44b9329af7cf7c6c275ffa01a195b6fdKey changes:
Potential problems:
Commit 214c2e2d1f3f68bc98ff20c6b5890661b2153fbdKey changes:
Potential problems:
Commit fb8da6d07a056b66af02fa9440bd043ad9358914Key changes:
Potential problems:
Commit 3918ea63df7ef9bd58688f618fa72972f875cea0Key changes:
Potential problems:
Commit 28086792e812707272ec9d34adc5b41e8f967241Key changes:
Potential problems:
Commit 513f18e49f6b37ee695b0e17afd94abd23e0706cKey changes:
Potential problems:
Commit 2adbc0af890a818b06a2d3b30081690660e5c468Key changes:
Potential problems:
Commit 424706faef76f8863ab2f205048a913328ac7559Key changes:
Potential problems:
Commit 0cfabfe292964ca834d8bf2f974e30da543d8ac1Key changes:
Potential problems:
Overall, it seems that the main intention of this patch is to update the workflow by adding an |
@hydai Could you please help review this PR? Please ignore the failed |
@hydai Thanks for the review! |
* [Refactor] Add #[form] for subtypes of WasmEdgeError. Signed-off-by: csh <[email protected]> * [Refactor] fix memory leak Signed-off-by: csh <[email protected]> * [Fix] Avoid the CPU 100% by tokio-wasi. Signed-off-by: csh <[email protected]> * [Fix] Fix blocking during tokio-wasi TCP connect. Signed-off-by: csh <[email protected]> * [Fix] async-wasi get envs & args Signed-off-by: csh <[email protected]> * [Perf] Optimize the wasi-ctx Signed-off-by: csh <[email protected]> * [Chore] Temporarily disable the serialize feature. Signed-off-by: csh <[email protected]> * [feat] virtual file system Signed-off-by: csh <[email protected]> * [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76) * [Feat] run func timeout use std::time::Duration Signed-off-by: csh <[email protected]> * [Doc]: update api docs Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> (cherry picked from commit 07e84b7) Signed-off-by: csh <[email protected]> * [Refactor] delete useless code from validator Signed-off-by: csh <[email protected]> * [Refactor] To pass the clippy Signed-off-by: csh <[email protected]> * Disable timeout in musl libc (#71) Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: csh <[email protected]> * Disable timeout in musl libc Signed-off-by: csh <[email protected]> * [Doc] update doc Signed-off-by: csh <[email protected]> * [Fix] fix ffi::WasmEdge_String to String Signed-off-by: csh <[email protected]> * [Fix] Fix unit test Signed-off-by: csh <[email protected]> * [Fix] Modify the `WasiModule`. Signed-off-by: csh <[email protected]> * [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84) * feat(rust-sys): drop host_data in `Function::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update `drop` of `ImportModule` and `Function` Signed-off-by: Xin Liu <[email protected]> * refactor(rust-sys): update `ImportModule::drop` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): remove debug code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): remove debug code Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.0` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): supress clippy warning Signed-off-by: Xin Liu <[email protected]> * ci(ci-build): update rust version Signed-off-by: Xin Liu <[email protected]> * ci(standalone): update rust version Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update rustdoc and `README` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependencies Signed-off-by: Xin Liu <[email protected]> * ci: update to `macos-13` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#85) Signed-off-by: Xin Liu <[email protected]> * [Chore] Update build script (#86) * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update build script Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Fix sys test Signed-off-by: csh <[email protected]> * Relax the version of `wat` dep (#90) * chore(rust-sdk): update `wat` dep Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update test code Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update test code Signed-off-by: Xin Liu <[email protected]> * version(rust-sys): bump to `0.17.4` Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.1` Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [CI] skip test_vmbuilder on fedora Signed-off-by: csh <[email protected]> * Fix static build to link agains zstd (#91) Signed-off-by: Jorge Prendes <[email protected]> * Update doc for releasing `v0.13.2` (#93) * ci: update workflows Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): fix typo Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update rustdoc Signed-off-by: Xin Liu <[email protected]> * version(rust-sdk): bump to `0.13.2` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Version] Bump `wasmedge-sys` to `v0.17.5` (#94) * version(rust-sys): bump to `0.17.5` Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update versioning table Signed-off-by: Xin Liu <[email protected]> * chore(rust-sys): update dependency Signed-off-by: Xin Liu <[email protected]> * chore(rust-sdk): update versioning table Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * doc: update `CHANGELOG` (#95) Signed-off-by: Xin Liu <[email protected]> * [CI] Update `rust-static-lib` workflow (#96) * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): update workflow Signed-off-by: Xin Liu <[email protected]> * ci(rust-static-lib): remove `libboost-all-dev` dep Signed-off-by: Xin Liu <[email protected]> --------- Signed-off-by: Xin Liu <[email protected]> * [Fix] Temporary FuncRef extraction implementation. Signed-off-by: csh <[email protected]> * [CI] fix test wat Signed-off-by: csh <[email protected]> --------- Signed-off-by: csh <[email protected]> Signed-off-by: Jorge Prendes <[email protected]> Signed-off-by: Xin Liu <[email protected]> Co-authored-by: Jorge Prendes <[email protected]> Co-authored-by: Xin Liu <[email protected]>
No description provided.