-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 프로필/마이페이지 UI 작업 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Reportℹ️ Story 변경사항이 감지되지 않았습니다 이 PR에는 Story 변경이 없어서 빌드를 스킵했습니다.
|
📊 Coverage Report
📉 #104을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #104 +/- ##
===========================================
- Coverage 38.54% 35.59% -2.95%
===========================================
Files 83 91 +8
Lines 3225 3492 +267
Branches 166 174 +8
===========================================
Hits 1243 1243 0
+ Misses 1982 2249 +267 영향받은 파일✅ 이 PR로 영향받은 파일이 없습니다 수정된 모든 파일이 현재 coverage를 유지했습니다. |
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
…into chiyoung-feat/profile-ui
| profileImage: 'https://cdn.myapp.com/user/profile/123.png', | ||
| notification_enabled: '1', | ||
| profileImage: | ||
| 'https://images.unsplash.com/photo-1518020382113-a7e8fc38eac9?q=80&w=717&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아.. 이거보고 이미지 unsplash 쓰면 된다는걸 알았네요
맨날 이미지 테스트한다고 config 파일에 domains에 주소 넣고 이미지 테스트 했었는데..ㅜㅜ
| const ToggleUI = ({ value = false }: ToggleUIProps) => { | ||
| return ( | ||
| <div className='bg-mint-500 flex h-5 w-9 cursor-pointer rounded-full p-0.5'> | ||
| <m.div | ||
| className='bg-mono-white size-4 rounded-full' | ||
| animate={{ x: value ? 16 : 0 }} | ||
| transition={{ | ||
| type: 'spring', | ||
| duration: 0.3, | ||
| bounce: 0.3, | ||
| }} | ||
| /> | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
알림 on/off 시 색도 변경되었으면 합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 추후 적용해볼게요!
wooktori
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다:)
…into chiyoung-feat/profile-ui
📝 변경 사항
프로필/마이페이지 마크업 작업을 완료했습니다.
/mypage/profile/2🔗 관련 이슈
Closes #46
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요