Skip to content

Conversation

@Chiman2937
Copy link
Member

@Chiman2937 Chiman2937 commented Dec 8, 2025

📝 변경 사항

  • 프로필 수정 모달을 제작하였습니다.
  • Modal Padding 수치를 수정하였습니다. (24px => 20px)

Important

현재 Modal에 max-w 가 제대로 적용되지 않는 문제가 있는데, 추후 수정하겠습니다.


🔗 관련 이슈

Closes #49
Closes #81


🧪 테스트 방법

  • 수동 테스트 검증(로컬 환경)
  • 유닛 테스트 검증
  • 통합 테스트 검증

📸 스크린샷 (선택)

image image

📋 체크리스트

  • 관련 문서를 업데이트했습니다 (필요한 경우)
  • 테스트를 추가/수정했습니다 (필요한 경우)
  • Breaking change가 있다면 명시했습니다

💬 추가 코멘트


CodeRabbit Review는 자동으로 실행되지 않습니다.

Review를 실행하려면 comment에 아래와 같이 작성해주세요

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chiyoung-feat/profile-edit-modal

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

🎨 Storybook Report

ℹ️ Story 변경사항이 감지되지 않았습니다

이 PR에는 Story 변경이 없어서 빌드를 스킵했습니다.

Status Storybook Build Log Updated (UTC)
⏭️ Skipped - - 2025-12-08 09:09:53

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

🚀 PR Preview Report

Build가 성공적으로 완료되었습니다.

Preview에서 변경사항을 확인하세요.

Status Preview Build Log Updated (UTC)
✅ Ready Visit Preview View Logs 2025-12-08 09:11:38

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

📊 Coverage Report

Status Build Log Updated (UTC)
✅ Ready View Build 2025-12-08 09:10:10

📉 #112main에 병합하면 coverage가 1.75% 감소합니다.

Coverage 요약

@@             Coverage Diff             @@
##             main     #112       +/-   ##
===========================================
- Coverage   33.44%   31.69%    -1.75%     
===========================================
  Files          98      103        +5     
  Lines        3782     3997      +215     
  Branches      183      188        +5     
===========================================
+ Hits         1265     1267        +2     
+ Misses       2517     2730      +213     

영향받은 파일

파일 Coverage 변화
/home/runner/work/WeGo_FrontEnd/WeGo_FrontEnd/src/components/ui/modal/index.tsx 94.22% (+0.05%) ⬆️

@Chiman2937 Chiman2937 added the Ready For Review! 리뷰 받을 준비가 되었습니다. label Dec 8, 2025
accept='image/*'
initialImages={initialImages}
maxFiles={1}
mode='replace'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저번에 코멘트 남겼던 mode가 이렇게 사용되는군요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요! 프로필에서는 항상 이미지가 교체되기 때문에 replace를 적용했습니다 :)

Copy link
Contributor

@wooktori wooktori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@Chiman2937 Chiman2937 merged commit cda4abd into main Dec 8, 2025
5 checks passed
@Chiman2937 Chiman2937 deleted the chiyoung-feat/profile-edit-modal branch December 8, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review! 리뷰 받을 준비가 되었습니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[컴포넌트] Image Input 컴포넌트 2종 [마이 페이지] 프로필 수정 Form 작업

3 participants