[Feat] 프로필 수정 모달 UI 제작 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into chiyoung-feat/profile-edit-modal
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Reportℹ️ Story 변경사항이 감지되지 않았습니다 이 PR에는 Story 변경이 없어서 빌드를 스킵했습니다.
|
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
📊 Coverage Report
📉 #112을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #112 +/- ##
===========================================
- Coverage 33.44% 31.69% -1.75%
===========================================
Files 98 103 +5
Lines 3782 3997 +215
Branches 183 188 +5
===========================================
+ Hits 1265 1267 +2
+ Misses 2517 2730 +213 영향받은 파일
|
…into chiyoung-feat/profile-edit-modal
wooktori
reviewed
Dec 8, 2025
| accept='image/*' | ||
| initialImages={initialImages} | ||
| maxFiles={1} | ||
| mode='replace' |
Contributor
There was a problem hiding this comment.
저번에 코멘트 남겼던 mode가 이렇게 사용되는군요!
Member
Author
There was a problem hiding this comment.
맞아요! 프로필에서는 항상 이미지가 교체되기 때문에 replace를 적용했습니다 :)
…into chiyoung-feat/profile-edit-modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 변경 사항
Important
현재 Modal에 max-w 가 제대로 적용되지 않는 문제가 있는데, 추후 수정하겠습니다.
🔗 관련 이슈
Closes #49
Closes #81
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요