-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] Modal 구조 수정/버그 수정 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Modal 외부에서 Mousedown, 외부에서 Mouseup 발동된 경우에만 Modal 닫히도록 수정
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request adds a root wrapper element to the layout, refactors the modal system to include animation support with improved focus management and mouse interaction detection, adjusts modal styling, and adds accessibility improvements to file inputs by preventing tabbing through hidden elements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Key areas requiring attention:
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
📊 Coverage Report
📈 #116을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #116 +/- ##
===========================================
+ Coverage 30.39% 31.34% +0.95%
===========================================
Files 105 105 0
Lines 4188 4252 +64
Branches 191 201 +10
===========================================
+ Hits 1273 1333 +60
+ Misses 2915 2919 +4 영향받은 파일
|
🎨 Storybook Reportℹ️ Story 변경사항이 감지되지 않았습니다 이 PR에는 Story 변경이 없어서 빌드를 스킵했습니다.
|
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
| // Modal 외부 Mousedown => 내부 MouseUp 일 때 Modal이 닫히지 않음 | ||
| // Modal 내부 Mousedown => 외부 MouseUp 일 때 Modal이 닫히지 않음 | ||
| // Modal 외부 Mousedown => 외부 Mouseup 일 때 Modal 닫힘 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 것까지 생각하신다니.. 대단하십니다👍👍
wooktori
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
📝 변경 사항
💡 구조 수정
ModalProvider가 createPortal 수행
💡버그 수정
💡 그 외
ModalContent 컴포넌트에 max-w 스타일을 지정하여 최대 넓이를 지정할 수 있습니다.
440px - (16px * 2)만큼 차지 할 수 있습니다. (화면 최대 너비 - 양쪽 여백)layout.tsx 에 root 용 div를 추가했습니다.(Modal Open 시 외부 요소 aria-hidden, inert 적용을 위함)
🔗 관련 이슈
Closes #113
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요
Summary by CodeRabbit
New Features
Bug Fixes
Style
✏️ Tip: You can customize this high-level summary in your review settings.