-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 팔로잉 목록 api 및 msw 작업 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Reportℹ️ Story 변경사항이 감지되지 않았습니다 이 PR에는 Story 변경이 없어서 빌드를 스킵했습니다.
|
📊 Coverage Report
📉 #123을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #123 +/- ##
===========================================
- Coverage 29.11% 28.45% -0.66%
===========================================
Files 116 120 +4
Lines 4579 4685 +106
Branches 212 216 +4
===========================================
Hits 1333 1333 0
+ Misses 3246 3352 +106 영향받은 파일✅ 이 PR로 영향받은 파일이 없습니다 수정된 모든 파일이 현재 coverage를 유지했습니다. |
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
|
|
||
| const params = useSearchParams(); | ||
| const tab = params.get('tab') || 'following'; | ||
| if (!followers) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금도 좋지만, 나중에나 리팩토링 할 때 isLoading, isError을 활용하는 것도 좋을 거 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 연동할 때 추가하겠습니다!😀
📝 변경 사항
🔗 관련 이슈
Closes #70
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요