Skip to content

Conversation

@wooktori
Copy link
Contributor

📝 변경 사항

  • 버튼 height 수정.
  • variant 별로 맞지 않던 디자인 수정.
  • 기존 디자인에 추가된 variant 삭제.
  • compoundVariants를 이용해 disabled일 때 디자인 구조화.

🔗 관련 이슈

Closes #126


🧪 테스트 방법

  • 수동 테스트 검증(로컬 환경)
  • 유닛 테스트 검증
  • 통합 테스트 검증

📸 스크린샷 (선택)


📋 체크리스트

  • 관련 문서를 업데이트했습니다 (필요한 경우)
  • 테스트를 추가/수정했습니다 (필요한 경우)
  • Breaking change가 있다면 명시했습니다

💬 추가 코멘트


CodeRabbit Review는 자동으로 실행되지 않습니다.

Review를 실행하려면 comment에 아래와 같이 작성해주세요

@coderabbitai review

@wooktori wooktori self-assigned this Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

🎨 Storybook Report

변경 사항이 없습니다

모든 Story가 이전 빌드와 동일합니다.

Status Storybook Build Log Updated (UTC)
✅ Unchanged View Storybook View Build 2025-12-11 00:31:33

@github-actions github-actions bot requested a review from yoorli December 10, 2025 08:06
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

📊 Coverage Report

Status Build Log Updated (UTC)
✅ Ready View Build 2025-12-11 00:29:49

📈 #140main에 병합하면 coverage가 0.32% 증가합니다.

Coverage 요약

@@             Coverage Diff             @@
##             main     #140       +/-   ##
===========================================
+ Coverage   26.74%   27.06%    +0.32%     
===========================================
  Files         125      125         0     
  Lines        4980     5002       +22     
  Branches      221      221         0     
===========================================
+ Hits         1332     1354       +22     
  Misses       3648     3648         0     

영향받은 파일

이 PR로 영향받은 파일이 없습니다

수정된 모든 파일이 현재 coverage를 유지했습니다.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hwanwook-fix/button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

🚀 PR Preview Report

Build가 성공적으로 완료되었습니다.

Preview에서 변경사항을 확인하세요.

Status Preview Build Log Updated (UTC)
✅ Ready Visit Preview View Logs 2025-12-11 00:31:03

@wooktori wooktori added the Ready For Review! 리뷰 받을 준비가 되었습니다. label Dec 10, 2025
@wooktori wooktori merged commit fa888e7 into main Dec 11, 2025
6 checks passed
@wooktori wooktori deleted the hwanwook-fix/button branch December 11, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review! 리뷰 받을 준비가 되었습니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공용 컴포넌트] 버튼 수정 작업

3 participants