-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 모임 카드 태그 없을 때도 카드 레이아웃 공간 유지 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Report✅ 변경 사항이 없습니다 모든 Story가 이전 빌드와 동일합니다.
|
🎭 Playwright Report✨ E2E Test가 성공적으로 완료되었습니다. Test 요약 내용을 확인해주세요.
📊 Test Summary
📜 Test Details✅ Passed Tests (9)
|
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
📊 Coverage Report
📈 #172을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #172 +/- ##
===========================================
+ Coverage 37.80% 37.83% +0.03%
===========================================
Files 138 138 0
Lines 5549 5551 +2
Branches 227 226 -1
===========================================
+ Hits 2098 2100 +2
Misses 3451 3451 0 영향받은 파일
|
HopeFullee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잠을 허락하노라
| /> | ||
|
|
||
| <CardProfile nickName={nickName} profileImage={profileImage} /> | ||
| <div className='flex flex-col justify-between'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <div className='flex flex-col justify-between'> | |
| <div className='flex-col-between'> |
제가 만든 TW util 보시면 flex-center / flex-between / flex-col-center / flex-col-between 있습니다.
styles/layout.css 가서 보세용
|
|
||
| <div className='flex min-w-0 flex-1 flex-col'> | ||
| <h3 className='text-text-md-semibold w-full truncate text-gray-900'>{title}</h3> | ||
| <div className='flex min-w-0 flex-1 flex-col justify-between'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <div className='flex min-w-0 flex-1 flex-col justify-between'> | |
| <div className='flex-col-between min-w-0 flex-1'> |
여기두 제가 만든거 쓰면 훨신 짧아지쥬?
Co-authored-by: Hope <[email protected]>
Co-authored-by: Hope <[email protected]>
📝 변경 사항
태그가 없을 때도 공간을 유지하여 프로그래스 바와 버튼 위치 고정
CardTags컴포넌트에min-h-[20px]추가null을 반환하지 않고 빈 컨테이너 렌더링모임 탈퇴 버튼과 채팅 입장 버튼의 세로 위치 정렬
justify-between적용src/components/shared/card/card-tags/index.tsx: 태그 없을 때 공간 유지 로직 추가src/components/shared/card/index.tsx: 버튼 세로 정렬을 위한 레이아웃 구조 개선🔗 관련 이슈
Closes #
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요