[Feat] 모임상세 정보 바인딩 작업 / date 유틸함수 refactor / 디폴트 이미지 상수 파일 생성 #180
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // 나중에 회원 프로필, 모임 디폴트 시안 나오면 각각 '/public/default-images/' 경로에서 지정 | ||
| export const DEFAULT_PROFILE_IMAGE = | ||
| 'https://images.unsplash.com/photo-1518020382113-a7e8fc38eac9?q=80&w=717&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D'; | ||
|
|
||
| export const DEFAULT_GROUP_IMAGE = | ||
| 'https://images.unsplash.com/photo-1705599359461-f99dc9e80efa?q=80&w=1170&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ import { api } from '@/api/core'; | |
| import { | ||
| CreateGroupPayload, | ||
| CreateGroupResponse, | ||
| GetGroupDetailsResponse, | ||
| GetGroupsPayload, | ||
| GetGroupsResponse, | ||
| GetMyGroupsPayload, | ||
| GetMyGroupsResponse, | ||
| GroupIdPayload, | ||
| PreUploadGroupImagePayload, | ||
| PreUploadGroupImageResponse, | ||
| } from '@/types/service/group'; | ||
|
|
@@ -69,7 +69,19 @@ export const groupServiceRemote = () => ({ | |
| return api.post<CreateGroupResponse>('/groups/create', payload); | ||
| }, | ||
|
|
||
| getGroupDetails: (payload: GroupIdPayload) => { | ||
| return api.get<GetGroupDetailsResponse>(`/groups/${payload.groupId}`); | ||
| }, | ||
|
|
||
| attendGroup: (payload: GroupIdPayload) => { | ||
| return api.post<GetGroupDetailsResponse>(`/groups/${payload.groupId}/attend`); | ||
| }, | ||
|
|
||
| cancelGroup: (payload: GroupIdPayload) => { | ||
| return api.post<GetGroupDetailsResponse>(`/groups/${payload.groupId}/cancel`); | ||
| }, | ||
|
|
||
| deleteGroup: (payload: GroupIdPayload) => { | ||
| return api.delete(`/groups/${payload.groupId}`); | ||
| }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,103 +25,11 @@ const MeetupDetailPage = ({ params }: Props) => { | |
| return ( | ||
| <div> | ||
| <MeetupBannerImages images={data.images} /> | ||
| <MeetupDescriptions descriptions={data} /> | ||
| <MeetupMembers members={data.joinedMembers} /> | ||
| <MeetupButtons conditions={data} groupId={groupId} /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default MeetupDetailPage; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ export const MeetingList = ({ | |
| {meetings.map((meeting) => ( | ||
| <Card | ||
| key={meeting.id} | ||
| dateTime={formatDateTime(meeting.startTime)} | ||
| images={meeting.images} | ||
| leaveAndChatActions={ | ||
| showActions | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ interface Props { | |
| } | ||
|
|
||
| export const MeetupBannerImages = ({ images }: Props) => { | ||
| const hasImages = Boolean(images.length); | ||
|
|
||
| const defaultImageUrl = | ||
| 'https://images.unsplash.com/photo-1705599359461-f99dc9e80efa?q=80&w=1170&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,27 +2,33 @@ | |
|
|
||
| import { useRouter } from 'next/navigation'; | ||
|
|
||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| import Cookies from 'js-cookie'; | ||
|
|
||
| import { MeetupModal } from '@/components/pages/meetup/meetup-modal'; | ||
| import { Button } from '@/components/ui/button'; | ||
| import { useModal } from '@/components/ui/modal'; | ||
| import { GetGroupDetailsResponse } from '@/types/service/group'; | ||
|
|
||
| interface Props { | ||
| conditions: Pick< | ||
| GetGroupDetailsResponse, | ||
| 'userStatus' | 'createdBy' | 'participantCount' | 'maxParticipants' | ||
| >; | ||
| groupId: string; | ||
| } | ||
|
|
||
| export const MeetupButtons = ({ | ||
| conditions: { | ||
| userStatus: { isJoined }, | ||
| createdBy, | ||
| participantCount, | ||
| maxParticipants, | ||
| }, | ||
| groupId, | ||
| }: Props) => { | ||
| const [isHost, setIsHost] = useState<boolean | null>(null); | ||
| const { open } = useModal(); | ||
| const { push } = useRouter(); | ||
|
|
||
|
|
@@ -31,36 +37,41 @@ export const MeetupButtons = ({ progress: { current, max }, ownerInfo }: Props) | |
| push('/message/id'); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| const sessionId = Number(Cookies.get('userId')); | ||
| // eslint-disable-next-line react-hooks/set-state-in-effect | ||
| setIsHost(sessionId === createdBy.userId); | ||
| }, [createdBy]); | ||
|
Comment on lines
+40
to
+44
Contributor
There was a problem hiding this comment.
useEffect(() => {
- const sessionId = Number(Cookies.get('userId'));
- // eslint-disable-next-line react-hooks/set-state-in-effect
- setIsHost(sessionId === createdBy.userId);
+ const userIdCookie = Cookies.get('userId');
+ if (userIdCookie) {
+ const sessionId = Number(userIdCookie);
+ setIsHost(sessionId === createdBy.userId);
+ } else {
+ setIsHost(false);
+ }
}, [createdBy]);🤖 Prompt for AI Agents |
||
|
|
||
| return ( | ||
| <div className='sticky bottom-[56px] border-t-1 border-gray-200 bg-white px-4 py-3'> | ||
| {isJoined ? ( | ||
| <div className='flex gap-[10px]'> | ||
| <Button | ||
| className='flex-[1.2]' | ||
| variant='tertiary' | ||
| onClick={() => | ||
| open(<MeetupModal groupId={groupId} type={isHost ? 'delete' : 'cancel'} />) | ||
| } | ||
| > | ||
| {isHost ? '모임 취소' : '모임 탈퇴'} | ||
| </Button> | ||
| <Button | ||
| className='flex-2' | ||
| disabled={participantCount >= maxParticipants} | ||
| onClick={onEnterChatClick} | ||
| > | ||
| 채팅 입장 | ||
| </Button> | ||
| </div> | ||
| ) : ( | ||
| <Button | ||
| disabled={participantCount >= maxParticipants} | ||
| onClick={() => open(<MeetupModal groupId={groupId} type='attend' />)} | ||
| > | ||
| 참여하기 | ||
| </Button> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { GetGroupDetailsResponse } from '@/types/service/group'; | ||
|
|
||
| interface Props { | ||
| detail: GetGroupDetailsResponse['description']; | ||
| } | ||
|
|
||
| export const DescriptionDetail = ({ detail }: Props) => { | ||
| return ( | ||
| <div className='mt-6'> | ||
| <p className='text-text-md-regular break-keep text-gray-800'>{detail}</p> | ||
| </div> | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
외부 URL 의존성에 대한 리스크를 추적하세요.
현재 Unsplash 외부 URL을 사용하고 있어, 해당 이미지가 삭제되거나 변경될 경우 문제가 발생할 수 있습니다. 주석에서 언급한 대로 로컬 이미지로 교체하는 작업을 이슈로 추적하는 것을 권장합니다.
이 작업을 추적하기 위한 이슈를 생성해 드릴까요?
🤖 Prompt for AI Agents