-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 알림 엔드포인트 API함수/Hook 4종 추가 #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Report✅ 변경 사항이 없습니다 모든 Story가 이전 빌드와 동일합니다.
|
🎭 Playwright Report✨ E2E Test가 성공적으로 완료되었습니다. Test 요약 내용을 확인해주세요.
📊 Test Summary
📜 Test Details✅ Passed Tests (3)
|
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
📊 Coverage Report
📈 #237을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #237 +/- ##
===========================================
+ Coverage 38.08% 38.13% +0.05%
===========================================
Files 176 181 +5
Lines 7606 7638 +32
Branches 331 336 +5
===========================================
+ Hits 2897 2913 +16
+ Misses 4709 4725 +16 영향받은 파일
|
| const handleNotificationClick = () => { | ||
| try { | ||
| mutateAsync(item.id); | ||
|
|
||
| router.push(`${item.redirectUrl}`); | ||
| } catch {} | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
router.push 라는 성공 후 추가 로직이 존재하기 때문에 mutateAsync를 사용했다고 보면 될까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니당 mutateAsync 성공 후 페이지 이동이 되어야 해서요 :)
wooktori
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍔고생하셨습니다!🍔
📝 변경 사항
알림 엔드포인트 API함수/Hook 4종을 추가하였습니다.
🔗 관련 이슈
Closes #
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요