-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 구글 OAuth 로그인 추가 #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
google oauth
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Report✨ E2E Test가 성공적으로 완료되었습니다. Test 요약 내용을 확인해주세요.
📊 Test Summary
📜 Test Details✅ Passed Tests (3)
|
🎨 Storybook Report✅ 변경 사항이 없습니다 모든 Story가 이전 빌드와 동일합니다.
|
📊 Coverage Report
📉 #329을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #329 +/- ##
===========================================
- Coverage 37.33% 37.16% -0.17%
===========================================
Files 227 228 +1
Lines 10445 10589 +144
Branches 420 420 0
===========================================
+ Hits 3900 3935 +35
+ Misses 6545 6654 +109 영향받은 파일
|
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
Chiman2937
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
📝 변경 사항
src/components/pages/auth/login/login-form/index.tsxpath쿼리 파라미터를 읽어post_login_path로 sessionStorage에 저장하도록 처리normalizePath()로 외부 URL/비정상 경로를 방지하고, 기본값은/로 처리redirectUri:${window.location.origin}/auth/google/callbackstate:crypto.randomUUID()로 생성 후google_oauth_state로 저장client_id,redirect_uri,response_type=code,scope,state,prompt를 포함해 redirectsrc/components/pages/auth/login/login-sns-button/index.tsxsrc/app/auth/google/callback/page.tsxsrc/api/service/auth-service/index.tsexchangeGoogleCode)를 구현src/types/service/auth.tssrc/mock/service/auth/auth-handlers.tssrc/lib/auth/utils.tssrc/hooks/use-auth/use-auth-login/index.tsnormalizePath()를 공용 유틸로 추가해, 로그인 관련 로직에서 중복 구현 제거 및 일관된 경로 정규화를 적src/app/auth/privacy/page.tsx🔗 관련 이슈
Closes #196
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
NEXT_PUBLIC_GOOGLE_CLIENT_ID=1051850964002-gqjvvi6pqjpl7ctk64cdm0kqk6bb4083.apps.googleusercontent.com
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요