-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 모임 승인 페이지 리팩토링 및 스켈레톤 추가 #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Report✨ E2E Test가 성공적으로 완료되었습니다. Test 요약 내용을 확인해주세요.
📊 Test Summary
📜 Test Details✅ Passed Tests (3)
|
🎨 Storybook Report✅ 변경 사항이 없습니다 모든 Story가 이전 빌드와 동일합니다.
|
📊 Coverage Report
📉 #364을 main에 병합하면 coverage가 Coverage 요약@@ Coverage Diff @@
## main #364 +/- ##
===========================================
- Coverage 37.10% 36.97% -0.13%
===========================================
Files 234 236 +2
Lines 10738 10776 +38
Branches 422 424 +2
===========================================
Hits 3984 3984 0
+ Misses 6754 6792 +38 영향받은 파일✅ 이 PR로 영향받은 파일이 없습니다 수정된 모든 파일이 현재 coverage를 유지했습니다. |
🚀 PR Preview Report✨ Build가 성공적으로 완료되었습니다. Preview에서 변경사항을 확인하세요.
|
HopeFullee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뭔가 뭔가 엄청난 파일 체인지
|
|
||
| import { SCHEDULE_MIN_HEIGHT } from '../constants'; | ||
|
|
||
| export const MeetingsLoading = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| export const MeetingsLoading = () => ( | |
| export const MeetingsSkeleton = () => ( |
아까 카드에선 Skeleton이라고 명명했는데 Meeting은 Skeleton이라고 이름 안붙여서 뭔가 불편하네요
📝 변경 사항
🔗 관련 이슈
Closes #
🧪 테스트 방법
📸 스크린샷 (선택)
📋 체크리스트
💬 추가 코멘트
CodeRabbit Review는 자동으로 실행되지 않습니다.
Review를 실행하려면 comment에 아래와 같이 작성해주세요