Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

Made required changes to Syncloop-hackathon page #755

Closed
wants to merge 2 commits into from

Conversation

Susmita-Dey
Copy link
Contributor

@Susmita-Dey Susmita-Dey commented Aug 24, 2023

Fixes Issue

This PR fixes the following issues:

closes #issue-number

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

  • New Feature: Added a new "Resources" section to the navigation menu in ParticularHackathonPageContent.js.
  • Refactor: Removed the "Judges" section from the navigation menu in ParticularHackathonPageContent.js.
  • New Feature: Updated syncloop.js with new judge Rahul Khinchi, updated video and live URLs, and added links to Syncloop YouTube channel and Udemy course.
  • Bug Fix: Corrected the spelling of "August" in BiteSizeOtterize.js and KafkaWebinar.js.
  • New Feature: Added new speaker Olyvia Rakshit to KafkaWebinar.js.
  • Refactor: Updated PerticularhackathonPage.jsx to use getDate function instead of getDateTime, reordered sections, and updated button text and URL based on current date.

@coderabbitai
Copy link

coderabbitai bot commented Aug 24, 2023

Image description CodeRabbit

Walkthrough

This pull request introduces updates to the hackathon and webinar pages. It includes changes in the navigation menu, addition of new judges and speakers, updates to URLs, correction of date formats, and reordering of sections for better user experience.

Changes

File Summary
src/content/Hackathons/ParticularHackathonPageContent.js
src/content/Hackathons/syncloop.js
src/pages/PerticularhackathonPage.jsx
Removed "Judges" section from the navigation menu, added a new "Resources" section, updated judge details, URLs, dates, and reordered sections.
src/content/Webinars/BiteSizeOtterize.js
src/content/Webinars/KafkaWebinar.js
Corrected spelling of "August", added a new speaker with image, and updated date.

🐰💻

Code changes here, code changes there,

New faces appear, with knowledge to share.

Dates corrected, URLs renewed,

For a user experience, freshly brewed.

Sections reordered, resources abound,

In this codebase, improvements are found! 🎉

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Actionable comments generated: 1

Commits Files that changed from the base of the PR and between 9e7265c and 94e2b7f commits.
Files ignored due to filter (3)
  • src/assets/hackathon/syncloop/judge.jpg
  • src/assets/webinars/kafka/poster.png
  • src/assets/webinars/kafka/speaker1.jpg
Files selected for processing (5)
  • src/content/Hackathons/ParticularHackathonPageContent.js (2 hunks)
  • src/content/Hackathons/syncloop.js (5 hunks)
  • src/content/Webinars/BiteSizeOtterize.js (1 hunks)
  • src/content/Webinars/KafkaWebinar.js (2 hunks)
  • src/pages/PerticularhackathonPage.jsx (4 hunks)
Files skipped from review due to trivial changes (2)
  • src/content/Hackathons/ParticularHackathonPageContent.js
  • src/content/Webinars/BiteSizeOtterize.js
LGTM comments (Suppressed): 1
src/content/Webinars/KafkaWebinar.js (1)
  • 24-27: The spelling of "August" has been corrected from "Augest". This should resolve any potential issues with date parsing.
Additional comments (Suppressed): 11
src/content/Webinars/KafkaWebinar.js (2)
  • 1-6: The import of Speaker1 is new and seems to be used for the additional speaker added in this PR. Ensure that the image file speaker1.jpg exists at the specified path.

  • 28-40: A new speaker, Olyvia Rakshit, has been added to the speakers array. Ensure that all references to the speakers array throughout the codebase have been updated to handle multiple speakers if they were not doing so already.

src/content/Hackathons/syncloop.js (5)
  • 5-5: The new image import for 'Rahul' is added correctly. However, ensure that the image file 'judge.jpg' exists in the specified path and it's properly formatted.

  • 22-24: The videoUrl and liveUrl have been updated. Ensure these URLs are correct and accessible. Also, make sure they point to the intended video and live stream respectively.

  • 108-111: A new judge, Rahul Khinchi, has been added to the judges array. The information seems to be correctly structured. However, verify that the Twitter handle 'rahhulk7' is correct and active.

  • 119-120: The URL for the 'Syncloop Platform' link under the takepart section has been updated. Make sure this URL is correct and leads to the intended page.

  • 154-157: The dates for the event and winner announcement have been changed. Ensure these dates are correct and align with the actual schedule of the hackathon.

src/pages/PerticularhackathonPage.jsx (4)
  • 9-12: The getDateTime function has been replaced with the getDate function. Ensure that this change does not affect other parts of the codebase where date and time information is required.

  • 58-70: The logic for displaying the button text and URL has been updated. Previously, it was based on whether the current date is before or after the hackathon end date. Now, it's based on whether the current date is before the start date, between the start and end dates, or after the end date. This seems to be a more accurate way of determining what action the user should take. However, ensure that the content.liveUrl is available and valid when the button text is "Watch recording".

  • 293-296: The "Resources" section has been moved above the "Register" section. This change could improve the user experience by providing them with resources before they decide to register. However, make sure this change aligns with the overall design and user flow of the website.

  • 325-329: The condition for rendering the "Register" section has been updated. It now checks if the current date is before the hackathon end date, instead of checking if it's before the start date. This allows users to register even after the hackathon has started, which might be beneficial in some cases. However, ensure that this change aligns with the rules and guidelines of the hackathon.


Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
  • A review comment is a comment on a diff or a file and not a comment on the PR itself.
  • You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@Susmita-Dey Susmita-Dey reopened this Aug 24, 2023
@Susmita-Dey Susmita-Dey reopened this Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant