Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

fixed events btn #760

Closed
wants to merge 1 commit into from
Closed

Conversation

thejaysharma
Copy link

@thejaysharma thejaysharma commented Aug 24, 2023

Fixes Issue

This PR fixes the following issues:
The event button on the banner homepage of should redirect to events section of the homepage.
closes #748

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

"Refactor: Updated Navigation in Banner Component

  • The href attribute of the ButtonLink component within the Banner component has been updated. Previously, it redirected users to a new page /events. Now, it navigates users to the #events section on the current page. This change enhances user experience by providing smoother navigation and reducing page load times."

@coderabbitai
Copy link

coderabbitai bot commented Aug 24, 2023

Walkthrough

The change in the code is quite straightforward. It modifies the destination of a ButtonLink component within the Banner component. The link originally pointed to the /events page, but now it directs users to an anchor on the current page identified as #events.

Changes

File Summary
src/components/layout/Banner.jsx Modified the href attribute of a ButtonLink component from /events to #events.

🐇💻

A button once led astray,

Now finds its path in a new way.

From a distant page, it's been deterred,

To an anchor close, its journey's been referred. 🎉🔗

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 56c5a44 and 5f19afe commits.
Files selected for processing (1)
  • src/components/layout/Banner.jsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/components/layout/Banner.jsx

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Tag the bot with @coderabbitai in any review comment to ask it questions. The bot will not respond unless explicitly tagged.
  • A review comment is a comment on a diff or a file and not a comment on the PR itself.
  • You can use the mouse to select multiple lines of code to provide exact context to the bot.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah! This is your first Pull Request in our community, Congratulations 🎉 and thank you for your contribution! 🚀 The team will review it on availability 💫. In the meantime join our Discord server and checkout our YouTube channel.

@Chandraprakash-Darji
Copy link
Contributor

@thejaysharma it is meant to be open the events page

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The event button on the banner homepage of should redirect to events section of the homepage.
2 participants