-
Notifications
You must be signed in to change notification settings - Fork 314
modified: src/components/TweetCarousael/index.jsx #762
Conversation
solved issue WeMakeDevs#761 modified: tailwind.config.js added new breakpoint xsm @ 370px
WalkthroughThis update introduces responsive layout support to the TweetCarousel component and adds a new screen size breakpoint in the Tailwind CSS configuration. The changes enhance the visual presentation and adaptability of the tweet carousel across different screen sizes. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- src/components/TweetCarousael/index.jsx (1 hunks)
- tailwind.config.js (1 hunks)
Files skipped from review due to trivial changes (2)
- src/components/TweetCarousael/index.jsx
- tailwind.config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah! This is your first Pull Request in our community, Congratulations 🎉 and thank you for your contribution! 🚀 The team will review it on availability 💫. In the meantime join our Discord server and checkout our YouTube channel.
@theunhackable Nice work, Thanks for the contribution |
@Chandraprakash-Darji Should I close tis now>? This is my first contribution. I don't know what to do |
@theunhackable Now I will merge it, and your code will be merged in main branch |
solved issue #761
Fixes Issue
This PR fixes the following issues:
closes #761
Changes proposed
the
better-react-carousel
containsresponsiveLayout
prop which is used to make the carousel responsive. I used this to fix the issueReference:
Responsive Layout attribute in better-react-carousel
I thought that a
div
wrapper would be better to manageTweet
component as it gives more flexibility to modify the width usingTailwindCSS
classes. So I have added adiv
wrapper around Tweet component which helps to tweak width property directly.Also I have added an extra break point in
TailwindCSS
xsm
of370px
which can be used for smaller devices.Here comes all the changes proposed through this PR
Check List (Check all the boxes which are applicable)
Screenshots
This is screen shot after the problem is fixed

[fixed given problem]
Add all the screenshots which support your changes
Observations
I observed that this problem occours in small devices when we change size of the window using console tool. But once we refresh the website the Tweet components adjusted themselves. I don't this this would be a major problem as mostly small devices are used in potrait mode.
Before Refresh: 👇
After Refresh : 👇
Summary by CodeRabbit