Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

Fix iframe height #794

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Fix iframe height #794

merged 1 commit into from
Sep 23, 2023

Conversation

Susmita-Dey
Copy link
Contributor

@Susmita-Dey Susmita-Dey commented Sep 23, 2023

Fixes Issue

This PR fixes the following issues:

closes #issue-number

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

  • Refactor: Adjusted the iframeHeight state in the Register component to improve responsiveness and appearance of the iframe. The initial value is now 750, and the height adjusts based on window width.
  • Style: Updated the style attribute of an <iframe> element in the NewsLetter component to remove the scroll bar, enhancing the visual experience for users.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2023

Walkthrough

This pull request primarily focuses on enhancing the responsiveness and visual appeal of iframes in two components, Register and NewsLetter. The changes include adjustments to iframe height and overflow properties, and removal of scroll bars.

Changes

File Path Summary
.../IndividualWebinar/Register.jsx Updated iframeHeight state's initial value from 700 to 750. Adjusted height based on window width. Added overflow: hidden to iframe style for improved appearance.
.../layout/JoinUs/NewsLetter.jsx Removed scroll property from iframe style object, resulting in the iframe not having a scroll bar.

🐇💻

In the land of code, where the brackets lie,

Two iframes stood tall, reaching for the sky.

Their heights adjusted, their scrolls concealed,

A smoother user experience, this PR revealed.

So here's to the coder, with vision so bright,

Making interfaces a delightful sight! 🎉🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

@livecycle
Copy link

livecycle bot commented Sep 23, 2023

kunal

Your Livecycle playground is ready 🎉.

Playground version up to date (f2d018c)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

  • Kunal Kushwaha

invite

Click here to invite the rest of your team.

@Susmita-Dey Susmita-Dey merged commit 709ac0c into WeMakeDevs:main Sep 23, 2023
@github-actions github-actions bot added the team label Sep 23, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 2cd83b1 and e341c1d.
Files selected for processing (2)
  • src/components/PageComp/IndividualWebinar/Register.jsx (3 hunks)
  • src/components/layout/JoinUs/NewsLetter.jsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/components/layout/JoinUs/NewsLetter.jsx
Additional comments (Suppressed): 3
src/components/PageComp/IndividualWebinar/Register.jsx (3)
  • 4-4: The initial iframeHeight state value has been increased from 700 to 750. Ensure that this change does not negatively impact the layout or design of the iframe across different screen sizes.

  • 14-14: The default iframeHeight in the useEffect hook has been updated from 700 to 750. This change should be verified to ensure it doesn't cause any unexpected layout issues on larger screens.

  • 28-28: The style attribute of the iframe now includes overflow: 'hidden'. This hides any overflow content, which can improve the visual presentation of the iframe. However, make sure that no important content is being cut off due to this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant