Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

bug_fix: Website Link still open on the Same Tab #813

Closed
wants to merge 3 commits into from
Closed

bug_fix: Website Link still open on the Same Tab #813

wants to merge 3 commits into from

Conversation

malivinayak
Copy link

@malivinayak malivinayak commented Oct 17, 2023

Fixes Issue

This PR fixes the following issues:

Changes proposed

  • Removed target="_blank"
  • Redirected to website via external link

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

  • After clicking on image redirection window open on same page.
  • Redirection window will open wemakedevs.org in new tab
  • After successful redirect external link will redirect back to github page

Try it here

Summary by CodeRabbit

  • Documentation: Updated a hyperlink in the README file. This change is minor and does not affect the functionality of the software. It simply redirects users to a new URL when they click on a specific image. This update enhances the user's navigation experience by ensuring they are directed to the correct and most relevant information.

@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2023

Walkthrough

The change is a simple yet significant one, involving the modification of a hyperlink in the README.md file. The target attribute of an image link has been updated, ensuring the link directs to the correct resource.

Changes

File Summary
README.md The hyperlink of an image has been updated. The target attribute has been replaced with a new URL.

🐇

"In the realm of code, no change too small,

A hyperlink updated, standing tall.

A rabbit hops, a commit made,

In the grand scheme, a part well played. 🎉"


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 98e5969 and 9ce97a8.
Files selected for processing (1)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • README.md

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah! This is your first Pull Request in our community, Congratulations 🎉 and thank you for your contribution! 🚀 The team will review it on availability 💫. In the meantime join our Discord server and checkout our YouTube channel.

@malivinayak malivinayak closed this by deleting the head repository Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Website Link still open on the Same Tab.
1 participant