Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

fix:Responsiveness testimonials details #830

Closed
wants to merge 3 commits into from
Closed

fix:Responsiveness testimonials details #830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6964bff
fix:responsiveness testimonials details
techmannih Nov 27, 2023
5350bbc
correct class
techmannih Dec 2, 2023
2ab8081
correct tailwindcss class
techmannih Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Cards/TestimonialCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
const TestimonialCard = ({ src, description, from }) => {
return (
<div className='mb-10 flex h-full w-full flex-col items-center justify-center rounded-lg border border-content/20 bg-gradient-to-br from-content/0 to-content/10 p-4 py-8 text-center lg:flex-1'>
<div className='mb-10 flex h-full w-full max:md:w-72 flex-col items-center justify-center rounded-lg border border-content/20 bg-gradient-to-br from-content/0 to-content/10 p-4 py-8 text-center lg:flex-1'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one too.

<img
alt='testimonial'
className=' mb-2 inline-block h-20 w-20 rounded-full border-2 border-base-100 bg-base-100/10 object-cover object-center'
src={src}
/>
<p className='text-lg'>{description}</p>
<p className='text-lg max-md:w-64'>{description}</p>
Copy link

@coderabbitai coderabbitai bot Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class max-md:w-64 appears to be a typo. If this is intended for Tailwind CSS, it should be corrected to md:max-w-64.

- <p className='text-lg max-md:w-64'>{description}</p>
+ <p className='text-lg md:max-w-64'>{description}</p>
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
<p className='text-lg max-md:w-64'>{description}</p>
<p className='text-lg md:max-w-64'>{description}</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techmannih you need to fix this maybe? The max-md class doesn't exist in my knowledge. Also make sure that the UI looks appropriate after you correctly set the class.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like humans are talking. I'll be quiet for now. If you need me again, just tag @coderabbitai in a new comment.

<hr className='styled-hr styled-hr--light mx-auto my-4' />
<h2 className='text-sm font-medium text-content '>{from}</h2>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/Testimonials.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const Testimonials = ({
{tweetId ? (
<TweetCarousael tweetId={tweetId} setTweetId={setTweetId} />
) : (
<div className='flex flex-col gap-4'>
<div className='flex flex-col gap-4 max-md:w-80'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct it.

Copy link
Author

@techmannih techmannih Dec 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I change this class, code is working locally and this is correct class

<Carousel
cols={3}
rows={1}
Expand Down