react 19 update #2104
Open
react 19 update #2104
+7,443
−5,238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
arch1995
reviewed
Mar 27, 2025
| @@ -41,8 +41,8 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/runtime": "^7.x", | |||
| "react": "^18.x", | |||
| "react-dom": "^18.x", | |||
| "react": "^19.x", | |||
There was a problem hiding this comment.
Not sure if we want to change this
arch1995
reviewed
Mar 27, 2025
arch1995
reviewed
Mar 27, 2025
arch1995
reviewed
Mar 27, 2025
| handleSocialLoginHeight, | ||
| socialLoginsConfig, | ||
| isDark, | ||
| // isEmailPrimary, |
There was a problem hiding this comment.
Do we need to handle this ?
arch1995
reviewed
Mar 27, 2025
|
|
||
| function Login(props: LoginProps) { | ||
| const { | ||
| // appName, |
There was a problem hiding this comment.
Are we not allowing customization of appName and appLogo
arch1995
reviewed
Mar 27, 2025
| @@ -41,8 +41,8 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/runtime": "^7.x", | |||
| "react": "^18.x", | |||
arch1995
reviewed
Mar 27, 2025
| @@ -87,6 +87,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@coinbase/wallet-sdk": "^4.3.x", | |||
| "@types/react": "^18.3.12", | |||
There was a problem hiding this comment.
If we are changing to v19, change here as well
arch1995
reviewed
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link: https://toruslabs.atlassian.net/browse/PD-4057
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: