feat: prevent over-withdrawal of platform fees (#208)#277
Merged
Akshola00 merged 3 commits intoWeb3Novalabs:mainfrom Mar 31, 2026
Merged
Conversation
- Guard withdraw_platform_fees against withdrawing more than tracked PlatformFees balance (InsufficientFees) - Ensure admin cannot drain event pool funds via platform fee withdrawal - Add tests: over-withdrawal blocked, exact balance succeeds - Fix pre-existing merge conflicts in crowdfunding.rs and interfaces/crowdfunding.rs - Fix duplicate EventMetrics struct and StorageKey variants - Add missing StorageKey variants: AllEventsCount, AllEvents, TicketCount - Fix buy_ticket to record UserTicket and update PoolEventMetrics.total_collected - Fix pool_created event to call record_event for accurate event tracking - Fix test compilation issues across buy_ticket_test, crowdfunding_test, set_platform_fee_bps_test, upgrade_contract_test
Contributor
Author
|
i've tried everything to fix this but it isn't working |
Contributor
|
I can't merge until conflicts are solved |
Contributor
Author
|
@Akshola00 Resolved conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #208